[ovs-dev] [PATCH] ovn: add qos function.

Ben Pfaff blp at ovn.org
Wed Jul 12 04:36:48 UTC 2017


On Mon, Jun 26, 2017 at 10:06:17AM +0800, wang.qianyu at zte.com.cn wrote:
> The current qos function is used for geneve
> tunnel to control the traffic out the ovs. And have no to-port qos 
> control.
> 
> This patch do the modification as follow
> 1. change the qos configuration with direction to consistent with neutron
> qos rule. Add qos_ingress_max_rate, qos_ingress_burst, qos_egress_max_rate
> and qos_egress_burst to instead old qos_max_rate and qos_burst.
> 
> 2. By configure the interface table field of ingress_policing_rate and
> ingress_policing_bust to implement the ingress qos control.
> 
> 3. Add qos configuration to qos field of port table to implement egress 
> qos
> control.
> 
> 4. Add dpdk qos support.
> 
> Change-Id: Ie90364cb5bee7f6b7e3086e0867997f7edab7038

Thanks for working on OVN.

The patch is wordwrapped, so it cannot be applied.

I believe that this patch breaks backward compatibility with existing
Neutron and other CMSes that run on top of OVN, as well as between
ovn-northd and ovn-controller of different versions.  Backward
compatibility is important to us, so it would be better to preserve it.
I think that this could be done by simply keeping the existing names for
qos_max_rate and qos_burst.  I understand the desire to have systematic
names; this could be done by supporting the old names as synonyms for
the equivalent new ones.

The patch needs a Signed-off-by.  Please read the OVS contribution info
for a description of how to add one and what it means (the meaning is
important).

Please add an item to NEWS.

I'll look forward to the next version of the patch.

Thanks,

Ben.


More information about the dev mailing list