[ovs-dev] [PATCH 3/4] ofproto-dpif-xlate: drop L3 packets on L2 legacy port

[Jan Scheurich]

Yes, this is a bug fix for the merged PTAP series. It could be merged independently from patches 1 and 2.
I'm sure it is possible to strip down the PTAP unit tests additions in this patch to cover the fixed issue without using decap action (e.g. by sending a L3 packet from a ptap tunnel to the veth port)?
@Zoltan: could you perhaps create a stand-alone commit for this and keep the remainder of the encap/decap unit tests for v2 of this series?
Thanks, Jan

> -----Original Message-----
> From: Ben Pfaff [mailto:blp at ovn.org]
> Sent: Wednesday, 12 July, 2017 02:31
> To: Zoltán Balogh <zoltan.balogh at ericsson.com>
> Cc: 'dev at openvswitch.org' <dev at openvswitch.org>; Jan Scheurich <jan.scheurich at ericsson.com>; Georg Schmuecking
> <Georg.Schmuecking at ericsson.com>; Jiri Benc (jbenc at redhat.com) <jbenc at redhat.com>; Yang, Yi Y <yi.y.yang at intel.com>
> Subject: Re: [PATCH 3/4] ofproto-dpif-xlate: drop L3 packets on L2 legacy port
> 
> On Fri, Jun 30, 2017 at 03:29:35PM +0000, Zoltán Balogh wrote:
> > This commit drops packet during xlate if it is a L3 packet and output port
> > packet_type is legacy_l2. It completes PTAP unit tests with:
> >
> >   - Send L3 packet over patch port.
> >   - Output L2/L3 packet to ports with different packet_type properties.
> >
> > Signed-off-by: Zoltán Balogh <zoltan.balogh at ericsson.com>
> 
> This looks to me like a bug fix that should be applied even without
> patches 1 and 2.  Is that right?  I guess that the test does use the
> "decap" action--can the bug be triggered without "decap"?
> 
> Thanks,
> 
> Ben.