[ovs-dev] [patch_v4 5/8] Userspace Datapath: Add TFTP support.

[Ben Pfaff]

On Wed, Jul 05, 2017 at 09:32:23PM -0700, Darrell Ball wrote:
> Both ipv4 and ipv6 are supported. Also, NAT support is included.
> 
> Signed-off-by: Darrell Ball <dlu998 at gmail.com>

Thanks for adding TFTP support!

The new is_tftp_ctl() function is very similar to is_ftp_ctl().  I
suggest factoring out the common code.  Also, please write
        ntohs(uh->udp_dst) == CT_IPPORT_TFTP
as
        uh->udp_dst == htons(CT_IPPORT_TFTP)
to match our common practice.

Thanks,

Ben.