[ovs-dev] [PATCH 12/40] datapath-windows: Add annotations for OvsAcquireCtrlLock

Shashank Ram rams at vmware.com
Fri Jul 14 17:03:58 UTC 2017





________________________________________
From: ovs-dev-bounces at openvswitch.org <ovs-dev-bounces at openvswitch.org> on behalf of Alin Serdean <aserdean at cloudbasesolutions.com>
Sent: Thursday, July 13, 2017 9:40 PM
To: dev at openvswitch.org
Subject: [ovs-dev] [PATCH 12/40] datapath-windows: Add annotations for OvsAcquireCtrlLock

Add annotations to the function `OvsAcquireCtrlLock`.
We make it aware that it raises the dispatch level, where it saves the
dispatch level and it acquires a lock.

Signed-off-by: Alin Gabriel Serdean <aserdean at cloudbasesolutions.com>
---
 datapath-windows/ovsext/Datapath.c | 1 +
 datapath-windows/ovsext/Datapath.h | 3 +++
 2 files changed, 4 insertions(+)

diff --git a/datapath-windows/ovsext/Datapath.c b/datapath-windows/ovsext/Datapath.c
index 6a170a0..732fcb0 100644
--- a/datapath-windows/ovsext/Datapath.c
+++ b/datapath-windows/ovsext/Datapath.c
@@ -429,6 +429,7 @@ OvsCleanup()
     }
 }

+_Use_decl_annotations_
 VOID
 OvsAcquireCtrlLock()
 {
diff --git a/datapath-windows/ovsext/Datapath.h b/datapath-windows/ovsext/Datapath.h
index 57b483a..86dd987 100644
--- a/datapath-windows/ovsext/Datapath.h
+++ b/datapath-windows/ovsext/Datapath.h
@@ -75,6 +75,9 @@ POVS_OPEN_INSTANCE OvsGetOpenInstance(PFILE_OBJECT fileObject,

 NTSTATUS OvsCompleteIrpRequest(PIRP irp, ULONG_PTR infoPtr, NTSTATUS status);

+_IRQL_raises_(DISPATCH_LEVEL)
+_IRQL_saves_global_(OldIrql, gOvsCtrlLock)
+_Acquires_lock_(gOvsCtrlLock)
 VOID OvsAcquireCtrlLock();
 VOID OvsReleaseCtrlLock();

--
2.10.2.windows.1
_______________________________________________

Acked-by: Shashank Ram <rams at vmware.com>


More information about the dev mailing list