[ovs-dev] [PATCH 00/40] Fix static code analysis warnings.

[Shashank Ram]

Alin, thanks a lot for this important series! Could you please test out all these changes with Driver verifier and ensure that it does not introduce new regressions such as memory leaks, deadlocks etc.

Thanks,
Shashank

________________________________________
From: ovs-dev-bounces at openvswitch.org <ovs-dev-bounces at openvswitch.org> on behalf of Alin Serdean <aserdean at cloudbasesolutions.com>
Sent: Thursday, July 13, 2017 9:40:51 PM
To: dev at openvswitch.org
Subject: [ovs-dev] [PATCH 00/40] Fix static code analysis warnings.

The following patches are fixes found with the WDK 8.1 and 10
static code analysis.

Alin Serdean (40):
Found with WDK 10
  datapath-windows: Use only non executable memory
  datapath-windows: Use non-executable memory when allocating memory
  datapath-windows: Remove annotations in Switch.c
  datapath-windows: interfaceName overflow in IpHelper
  datapath-windows: Fix possible NULL dereference in IpFragment
  datapath-windows: Fix aligment in Stt
  datapath-windows: Add asserts to Stt
  datapath-windows: Suppress PAGED_CODE warnings
  datapath-windows: Fix possible NULL dereference in BufferMgmt
  datapath-windows: Fix possible NULL deference
  datapath-windows: Add an assert in recirculation
  datapath-windows: Add annotations for OvsAcquireCtrlLock
  datapath-windows: Add annotations for OvsReleaseCtrlLock
  datapath-windows: Remove function declarations from Tunnel.c
  datapath-windows: Add function annotations for OvsAcquireDatapathRead
  datapath-windows: Add function annotations for OvsAcquireDatapathWrite
  datapath-windows: Add function annotations for OvsReleaseDatapath
  datapath-windows: Add function annotations for OvsCancelIrp
  datapath-windows: Add function annotations for OvsTunnelFilterCancelIrp
  datapath-windows: Add function annotations for OvsCancelIrpDatapath
  datapath-windows: Add function annotations for OvsAcquireEventQueueLock
  datapath-windows: Add annotations for OvsReleaseEventQueueLock
  datapath-windows: Add annotations for OvsReleasePidHashLock
  datapath-windows: Add annotations for OvsAcquirePidHashLock
  datapath-windows: Fix spelling for OvsTunnelFilterSetIrpContext
  datapath-windows: Use annotations instead for macros
  datapath-windows: Add assert in OvsPartialCopyNBL
  datapath-windows: Fix possible NULL deference in OvsFullCopyNBL
  datapath-windows: Suppress warning in jhash
  datapath-windows: Add dummy parameter for NotifyRouteChange2
Found with WDK 8.1
  datapath-windows: prettify logging in iphelper
  datapath-windows: fix excessive stack usage in iphelper
  datapath-windows: Check return status when using APIs
  datapath-windows: Vport check RtlStringCbLengthW return value
  datapath-windows: Treat TCP_HDR_LEN static analysis warnings
  datapath-windows: Add annotation for OvsCtRelatedEntryCleaner
  datapath-windows: Add annotation for OvsIpFragmentEntryCleaner
  datapath-windows: Fix shared variables which use Interlocked functions
  datapath-windows: Fix static analysis warnings in OvsGetTcpPayloadLength
  datapath-windows: Fix static analysis warnings around ovsInstanceListLock

 datapath-windows/ovsext/Actions.c           |  5 +++
 datapath-windows/ovsext/BufferMgmt.c        | 18 ++++++----
 datapath-windows/ovsext/Conntrack-related.c |  7 ++--
 datapath-windows/ovsext/Conntrack.h         | 17 ++++-----
 datapath-windows/ovsext/Datapath.c          |  8 +++--
 datapath-windows/ovsext/Datapath.h          |  8 +++++
 datapath-windows/ovsext/Debug.h             | 18 ----------
 datapath-windows/ovsext/Event.c             |  8 +++++
 datapath-windows/ovsext/Flow.c              |  2 +-
 datapath-windows/ovsext/Geneve.c            |  5 ++-
 datapath-windows/ovsext/Gre.c               |  3 +-
 datapath-windows/ovsext/IpFragment.c        |  4 +--
 datapath-windows/ovsext/IpHelper.c          | 53 +++++++++++++++++------------
 datapath-windows/ovsext/Jhash.c             |  2 ++
 datapath-windows/ovsext/NetProto.h          |  2 +-
 datapath-windows/ovsext/Offload.c           |  9 +++--
 datapath-windows/ovsext/PacketParser.c      |  3 +-
 datapath-windows/ovsext/Stt.c               | 14 ++++----
 datapath-windows/ovsext/Switch.c            |  8 ++---
 datapath-windows/ovsext/Switch.h            | 10 ++++++
 datapath-windows/ovsext/Tunnel.c            | 10 ------
 datapath-windows/ovsext/TunnelFilter.c      |  5 ++-
 datapath-windows/ovsext/User.c              |  8 +++++
 datapath-windows/ovsext/Util.c              |  9 +++--
 datapath-windows/ovsext/Util.h              | 21 ++++++++++++
 datapath-windows/ovsext/Vport.c             |  9 +++--
 datapath-windows/ovsext/Vxlan.c             |  7 ++--
 27 files changed, 161 insertions(+), 112 deletions(-)

--
2.10.2.windows.1
_______________________________________________
dev mailing list
dev at openvswitch.org
https://urldefense.proofpoint.com/v2/url?u=https-3A__mail.openvswitch.org_mailman_listinfo_ovs-2Ddev&d=DwICAg&c=uilaK90D4TOVoH58JNXRgQ&r=6OuVHk-mnufSWzkKa74UkQ&m=4_aantYcWkgldEbd8X-s9FXQ8EGQRtaF2Eqi9ayiKbo&s=jJhd646Ak7DRhcVsVX9_Z5wcuPk0zJJ9jGsj36p6U1o&e=