[ovs-dev] [PATCH net] openvswitch: Fix for force/commit action failures

Joe Stringer joe at ovn.org
Fri Jul 14 18:29:59 UTC 2017


On 14 July 2017 at 09:10, Greg Rose <gvrose8192 at gmail.com> wrote:
> When there is an established connection in direction A->B, it is
> possible to receive a packet on port B which then executes
> ct(commit,force) without first performing ct() - ie, a lookup.
> In this case, we would expect that this packet can delete the existing
> entry so that we can commit a connection with direction B->A. However,
> currently we only perform a check in skb_nfct_cached() for whether
> OVS_CS_F_TRACKED is set and OVS_CS_F_INVALID is not set, ie that a
> lookup previously occurred. In the above scenario, a lookup has not
> occurred but we should still be able to statelessly look up the
> existing entry and potentially delete the entry if it is in the
> opposite direction.
>
> This patch extends the check to also hint that if the action has the
> force flag set, then we will lookup the existing entry so that the
> force check at the end of skb_nfct_cached has the ability to delete
> the connection.
>
> Fixes: dd41d330b03 ("openvswitch: Add force commit.")
> CC: Pravin Shelar <pshelar at nicira.com>
> CC: dev at openvswitch.org
> Signed-off-by: Joe Stringer <joe at ovn.org>
> Signed-off-by: Greg Rose <gvrose8192 at gmail.com>
> ---

Thanks for the fix.

Reviewed-by: Joe Stringer <joe at ovn.org>


More information about the dev mailing list