[ovs-dev] [PATCH] checkpatch: Check for trailing operators.

Joe Stringer joe at ovn.org
Fri Jul 14 21:22:16 UTC 2017


On 14 July 2017 at 14:03, Ben Pfaff <blp at ovn.org> wrote:
> On Fri, Jul 14, 2017 at 01:59:06PM -0700, Joe Stringer wrote:
>> The style guide states that lines should not end with '&&', '||' '&'
>> '|', '?', ':'. Check for this and report an error.
>>
>> Signed-off-by: Joe Stringer <joe at ovn.org>
>
> Hmm, is that right?  It's pretty explicit about ?:, but I don't know
> about the others.

Ah, right you are. It's not explicit about the others. That said,
following the explicit description for ?: there's a few examples that
apply this style also to &&,||,&,|. I can respin this patch if you
think this is too strict.


More information about the dev mailing list