[ovs-dev] [PATCH v2 1/4] xlate: Refactor translation of patch port output actions.

Joe Stringer joe at ovn.org
Fri Jul 14 23:35:26 UTC 2017


On 4 July 2017 at 02:46, Sugesh Chandran <sugesh.chandran at intel.com> wrote:
> Outputting to a patch port is translated by its peer patch port actions.
> Refactoring the translation part to use later in the patch series for the
> tunnel push.
>
> Signed-off-by: Sugesh Chandran <sugesh.chandran at intel.com>
> Signed-off-by: Zoltán Balogh <zoltan.balogh at ericsson.com>
> Co-authored-by: Zoltán Balogh <zoltan.balogh at ericsson.com>
> ---

Thanks for the patch, and sorry about the delay while I was traveling.

I'll apply this soon with the following incremental:

diff --git a/ofproto/ofproto-dpif-xlate.c b/ofproto/ofproto-dpif-xlate.c
index c4dd3a729e6e..004585cef060 100644
--- a/ofproto/ofproto-dpif-xlate.c
+++ b/ofproto/ofproto-dpif-xlate.c
@@ -3302,9 +3302,8 @@ apply_nested_clone_actions(struct xlate_ctx
*ctx, const struct xport *in_dev,
    memset(flow->regs, 0, sizeof flow->regs);
    flow->actset_output = OFPP_UNSET;
    clear_conntrack(ctx);
-    ctx->xin->trace = xlate_report(ctx, OFT_BRIDGE,
-                                           "bridge(\"%s\")",
-                                           out_dev->xbridge->name);
+    ctx->xin->trace = xlate_report(ctx, OFT_BRIDGE, "bridge(\"%s\")",
+                                   out_dev->xbridge->name);
    mirror_mask_t old_mirrors = ctx->mirrors;
    bool independent_mirrors = out_dev->xbridge != ctx->xbridge;
    if (independent_mirrors) {
@@ -3388,6 +3387,7 @@ apply_nested_clone_actions(struct xlate_ctx
*ctx, const struct xport *in_dev,
    }
    if (ctx->xin->xcache) {
        struct xc_entry *entry;
+
        entry = xlate_cache_add_entry(ctx->xin->xcache, XC_NETDEV);
        entry->dev.tx = netdev_ref(in_dev->netdev);
        entry->dev.rx = netdev_ref(out_dev->netdev);


More information about the dev mailing list