[ovs-dev] [PATCH v1 4/4] ovn: l3ha fix bundle action generation

Miguel Angel Ajo majopela at redhat.com
Tue Jul 18 14:53:30 UTC 2017


The bundle pointer wasn't properly re-pointed each time
we added a new slave port to the openflow action.

Signed-off-by: Miguel Angel Ajo <majopela at redhat.com>
---
 ovn/controller/physical.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/ovn/controller/physical.c b/ovn/controller/physical.c
index 1d0fe7f..719b020 100644
--- a/ovn/controller/physical.c
+++ b/ovn/controller/physical.c
@@ -695,16 +695,17 @@ consider_port_binding(enum mf_field_id mff_ovn_geneve,
                     }
                     ofpbuf_put(ofpacts_p, &tun->ofport,
                                sizeof tun->ofport);
+                    bundle = ofpacts_p->header;
                     bundle->n_slaves++;
                 }
             }
 
-            ofpact_finish_BUNDLE(ofpacts_p, &bundle);
             bundle->algorithm = NX_BD_ALG_ACTIVE_BACKUP;
             /* Although ACTIVE_BACKUP bundle algorithm seems to ignore
              * the next two fields, those are always set */
             bundle->basis = 0;
             bundle->fields = NX_HASH_FIELDS_ETH_SRC;
+            ofpact_finish_BUNDLE(ofpacts_p, &bundle);
         }
         ofctrl_add_flow(flow_table, OFTABLE_REMOTE_OUTPUT, 100, 0,
                         &match, ofpacts_p);
-- 
1.8.3.1



More information about the dev mailing list