[ovs-dev] [PATCH] tests: Add force/commit test to system-traffic.at

Greg Rose gvrose8192 at gmail.com
Tue Jul 18 15:08:07 UTC 2017


On 07/17/2017 12:35 PM, Joe Stringer wrote:
> On 17 July 2017 at 12:27, Darrell Ball <dball at vmware.com> wrote:
> >
> >
> > On 7/17/17, 11:26 AM, "Greg Rose" <gvrose8192 at gmail.com> wrote:
> >
> >      On 07/17/2017 11:23 AM, Darrell Ball wrote:
> >      >
> >      >
> >      > On 7/17/17, 10:44 AM, "ovs-dev-bounces at openvswitch.org on behalf of gvrose8192 at gmail.com" <ovs-dev-bounces at openvswitch.org on behalf of gvrose8192 at gmail.com> wrote:
> >      >
> >      >      From: Greg Rose <gvrose8192 at gmail.com>
> >      >
> >      >      Add a new test for the kernel module datapath to test if the
> >      >      conntrack force direction change and commit is working correctly.
> >      >
> >      > Although the kind of problem that the associated code fix
> >      > https://urldefense.proofpoint.com/v2/url?u=https-3A__patchwork.ozlabs.org_patch_789646_&d=DwICaQ&c=uilaK90D4TOVoH58JNXRgQ&r=BVhFA09CGX7JQ5Ih-uZnsw&m=n3KZl3lnE-vdWgXO9q3zBE7yv11YOv51N2FWOarYEbk&s=0eYyRkq_xYLqcz617OlfxQ_vR4MDvowvLfPUwLf0C5U&e=
> >      > addresses is specifically related to kernel conntrack, the test added covers both kernel and
> >      > userspace conntrack and runs on both.
> >      > You may want to update the above text accordingly.
> >
> >      I did not know that.
> >
> >      I can send a V2 or Joe can fix before pushing.  Either way is fine by me.
> >
> >      Thanks,
> >
> >      - Greg
> >
> > same here
> >
> > The test command for the userspace side is:
> >
> > dball at ubuntu:~/openvswitch/ovs$ sudo make check-system-userspace TESTSUITEFLAGS='19' -C _gcc
> > [sudo] password for dball:
> > make: Entering directory `/home/dball/openvswitch/ovs/_gcc'
> > make  all-recursive
> > make[1]: Entering directory `/home/dball/openvswitch/ovs/_gcc'
> > Making all in datapath
> > make[2]: Entering directory `/home/dball/openvswitch/ovs/_gcc/datapath'
> > Making all in linux
> > make[3]: Entering directory `/home/dball/openvswitch/ovs/_gcc/datapath/linux'
> > make -C /lib/modules/3.19.0-25-generic/build M=/home/dball/openvswitch/ovs/_gcc/datapath/linux modules
> > make[4]: Entering directory `/usr/src/linux-headers-3.19.0-25-generic'
> >    Building modules, stage 2.
> >    MODPOST 6 modules
> > make[4]: Leaving directory `/usr/src/linux-headers-3.19.0-25-generic'
> > make[3]: Leaving directory `/home/dball/openvswitch/ovs/_gcc/datapath/linux'
> > make[3]: Entering directory `/home/dball/openvswitch/ovs/_gcc/datapath'
> > make[3]: Leaving directory `/home/dball/openvswitch/ovs/_gcc/datapath'
> > make[2]: Leaving directory `/home/dball/openvswitch/ovs/_gcc/datapath'
> > make[2]: Entering directory `/home/dball/openvswitch/ovs/_gcc'
> > make[3]: Entering directory `/home/dball/openvswitch/ovs/_gcc/datapath'
> > make[3]: `distfiles' is up to date.
> > make[3]: Leaving directory `/home/dball/openvswitch/ovs/_gcc/datapath'
> > make[2]: Leaving directory `/home/dball/openvswitch/ovs/_gcc'
> > make[1]: Leaving directory `/home/dball/openvswitch/ovs/_gcc'
> > set /bin/bash '../tests/system-userspace-testsuite' -C tests  AUTOTEST_PATH='utilities:vswitchd:ovsdb:vtep:tests::ovn/controller-vtep:ovn/northd:ovn/utilities:ovn/controller' 19 -j1; \
> >          "$@" || (test X'' = Xyes && "$@" --recheck)
> > ## ------------------------------ ##
> > ## openvswitch 2.7.90 test suite. ##
> > ## ------------------------------ ##
> >   19: conntrack - force commit                        ok
> >
> > ## ------------- ##
> > ## Test results. ##
> > ## ------------- ##
> >
> > 1 test was successful.
> > make: Leaving directory `/home/dball/openvswitch/ovs/_gcc'
>
> Thanks for trying it out. I'll hold off on applying this until we get
> the kernel side in.
>
I'll send a V2 shortly.

Thanks,

- Greg


More information about the dev mailing list