[ovs-dev] [PATCH v2] Update relevant artifacts to add support for DPDK 17.05.1.
Aaron Conole
aconole at redhat.com
Tue Jul 18 17:44:59 UTC 2017
Hi (again) Michal,
Michal Weglicki <michalx.weglicki at intel.com> writes:
> Upgrading to DPDK 17.05.1 stable release adds new
> significant features relevant to OVS, including,
> but not limited to:
> - tun/tap PMD,
> - VFIO hotplug support,
> - Generic flow API.
>
> Following changes are applied:
> - netdev-dpdk: Changes required by DPDK API modifications.
> - doc: Because of DPDK API changes, backward compatibility
> with previous DPDK releases will be broken, thus all
> relevant documentation entries are updated.
> - .travis: DPDK version change from 16.11.1 to 17.05.1.
> - rhel/openvswitch-fedora.spec.in: DPDK version change
> from 16.11 to 17.05.1
>
> v1->v2: Patch rebase.
>
> Signed-off-by: Michal Weglicki <michalx.weglicki at intel.com>
> ---
There is a problem with this patch, specifically:
> Documentation/intro/install/dpdk.rst | 60 ++++++-------
> --- a/Documentation/intro/install/dpdk.rst
> +++ b/Documentation/intro/install/dpdk.rst
> @@ -1,25 +1,25 @@
> ..
> - Licensed under the Apache License, Version 2.0 (the "License"); you may
> - not use this file except in compliance with the License. You may obtain
> - a copy of the License at
> +Licensed under the Apache License, Version 2.0 (the "License"); you may
> +not use this file except in compliance with the License. You may obtain
> +a copy of the License at
>
> - http://www.apache.org/licenses/LICENSE-2.0
> + http://www.apache.org/licenses/LICENSE-2.0
>
> - Unless required by applicable law or agreed to in writing, software
> - distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
> - WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
> - License for the specific language governing permissions and limitations
> - under the License.
> +Unless required by applicable law or agreed to in writing, software
> +distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
> +WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
> +License for the specific language governing permissions and limitations
> +under the License.
>
> - Convention for heading levels in Open vSwitch documentation:
> +Convention for heading levels in Open vSwitch documentation:
>
> - ======= Heading 0 (reserved for the title in a document)
> - ------- Heading 1
> - ~~~~~~~ Heading 2
> - +++++++ Heading 3
> - ''''''' Heading 4
> +======= Heading 0 (reserved for the title in a document)
> +------- Heading 1
> +~~~~~~~ Heading 2
> ++++++++ Heading 3
> +''''''' Heading 4
>
> - Avoid deeper levels because they do not render well.
> +Avoid deeper levels because they do not render well.
All of this white space change gets flagged as build warning. I think
the additional whitespace changes in this file also matter. Please fix
for the next version. You can keep my Reviewed-by: tag.
-Aaron
More information about the dev
mailing list