[ovs-dev] [PATCH V2] tests: Add force/commit test to system-traffic.at

Joe Stringer joe at ovn.org
Tue Jul 18 20:23:22 UTC 2017


On 18 July 2017 at 13:08, Greg Rose <gvrose8192 at gmail.com> wrote:
> On 07/18/2017 10:16 AM, Darrell Ball wrote:
>>
>>
>>
>> On 7/18/17, 8:42 AM, "ovs-dev-bounces at openvswitch.org on behalf of Greg
>> Rose" <ovs-dev-bounces at openvswitch.org on behalf of gvrose8192 at gmail.com>
>> wrote:
>>
>>      From: Joe Stringer <joe at ovn.org>
>>           Add a new test check if the conntrack force direction change and
>>      commit is working correctly.
>>
>> You are adding a new check to an existing test (‘force commit’).
>> The existing test already checked for conntrack force direction change.
>
>
> Oh.  OK, I just went from this change:
>
>  +priority=100,in_port=1,udp,action=ct(force,commit),controller
>
> And that looks like a new test for force and commit to me but
> obviously I don't know the entire context.
>
> Joe originated this patch and asked me to send it along with my
> other bug fix commit.  Clearly I need some help on what this
> patch is actually doing.  Let me see what he thinks.

In autotest parlance, the part between AT_SETUP and AT_CLEANUP is a
test, so you updated the test (which, yes, tests something slightly
more).

Don't worry about re-sending though, I can fix this up when I apply this.


More information about the dev mailing list