[ovs-dev] [PATCH 02/10] dpif-netlink: For non-Ethernet, use Ethertype from packet_type

Joe Stringer joe at ovn.org
Tue Jul 18 22:34:16 UTC 2017


On 10 July 2017 at 12:39, Eric Garver <e at erig.me> wrote:
> For non-Ethernet flows, when fixing up the netlink message we need make
> sure to pass down a valid Ethertype. The kernel does not understand
> packet_type so it's implicitly encoded by the absence of _ETHERNET and
> exact match of _ETHERTYPE. Without this change match_validate in the
> kernel complains when trying to match packets from L3 tunnels.
> e.g.
>   openvswitch: netlink: Unexpected mask (mask=110088, allowed=3d9804c)
>
> The mask use to always be set in xlate_wc_init() and xlate_wc_finish(),
> but that changed for non-Ethernet frames with the commit listed in
> Fixes.
>
> Fixes: 3d4b2e6eb74e ("userspace: Add OXM field MFF_PACKET_TYPE")
> Signed-off-by: Eric Garver <e at erig.me>
> ---

Hi Eric, thanks for the fix.

As we discussed off-list, I was trying to figure out if there's a way
to fix this up without the extra memory copies/moves. I have a
proposal to supersede the first two patches here:

https://mail.openvswitch.org/pipermail/ovs-dev/2017-July/335881.html

Let me know what you think of that approach. In the mean time I'll
continue review of this series.

Cheers,
Joe


More information about the dev mailing list