[ovs-dev] [PATCH v1 4/4] ovn: l3ha truncate log file in tests before action starts

Russell Bryant russell at ovn.org
Wed Jul 19 02:39:54 UTC 2017


On Tue, Jul 18, 2017 at 10:55 AM, Miguel Angel Ajo <majopela at redhat.com> wrote:
> An specific ovn/l3ha test looks for port releases in the MASTER
> gateway when another gateway on the Gateway_Chassis list is gone.
>
> But we didn't clean the log before taking out the chassis, so
> any previous unrelated occurrence could make the test fail
> while it was ok.
>
> Signed-off-by: Miguel Angel Ajo <majopela at redhat.com>
> ---
>  tests/ovn.at | 2 ++hy
>  1 file changed, 2 insertions(+)

Thanks, I applied this patch series to master.

While I was OK with applying patch 3 as it is to make the test more
reliable, can you expand on why you had to filter out packets?  Why
can't we have the test know exactly what packets to expect?

-- 
Russell Bryant


More information about the dev mailing list