[ovs-dev] [PATCH v2] netdev: check for NULL fields in netdev_get_addrs

Timothy M. Redaelli tredaelli at redhat.com
Wed Jul 19 13:38:45 UTC 2017


On 07/18/2017 05:25 PM, Daniel Alvarez Sanchez wrote:
> When the interfaces list is retrieved through getiffaddrs(), there
> might be elements with iface_name set to NULL.
> 
> This patch checks ifa_name to be not NULL before comparing it to the
> actual device name in the loop that calculates how many interfaces
> exist with that same name.
> 
> Also, this patch checks that ifa_netmask is not NULL for coherence
> with the existing code so that it doesn't allocate more memory
> than needed if this field is NULL.
> 
> Note, that these checks are already being done later in the function
> so it should be done in both places.
> 
> Signed-off-by: Daniel Alvarez <dalvarez at redhat.com>
> ---

Acked-by: Timothy Redaelli <tredaelli at redhat.com>


More information about the dev mailing list