[ovs-dev] [PATCH 6/8] datapath: Avoid using stack larger than 1024

[Joe Stringer]

On 19 July 2017 at 13:57, Greg Rose <gvrose8192 at gmail.com> wrote:
> Upstream commit:
>     commit 9cc9a5cb176ccb4f2cda5ac34da5a659926f125f
>     Author: Tonghao Zhang <xiangxia.m.yue at gmail.com>
>     Date:   Thu Jun 29 17:27:44 2017 -0700
>
>     datapath: Avoid using stack larger than 1024.
>
>     When compiling OvS-master on 4.4.0-81 kernel,
>     there is a warning:
>
>         CC [M]  /root/ovs/datapath/linux/datapath.o
>         /root/ovs/datapath/linux/datapath.c: In function
>         'ovs_flow_cmd_set':
>         /root/ovs/datapath/linux/datapath.c:1221:1: warning:
>         the frame size of 1040 bytes is larger than 1024 bytes
>         [-Wframe-larger-than=]
>
>     This patch factors out match-init and action-copy to avoid
>     "Wframe-larger-than=1024" warning. Because mask is only
>     used to get actions, we new a function to save some
>     stack space.
>
>     Signed-off-by: Tonghao Zhang <xiangxia.m.yue at gmail.com>
>     Acked-by: Pravin B Shelar <pshelar at ovn.org>
>     Signed-off-by: David S. Miller <davem at davemloft.net>
>
> Signed-off-by: Greg Rose <gvrose8192 at gmail.com>
> ---

It looks like Tonghao Zhang already backported this patch here:

http://patchwork.ozlabs.org/patch/783279/

Given that he is the original author and originally backported this, I
figure that we can take his copy of the patch.

Cheers,
Joe