[ovs-dev] [PATCH] datapath-windows: Fix a bug in OvsCreateNewNBLsFromMultipleNBs()

Shashank Ram rams at vmware.com
Fri Jul 21 18:57:44 UTC 2017


While creating a new NBL chain with 1 NB per NBL,
from an NBL that contains multiple NBs, the new NBL
chain was being broken, as a result leaking packets.

Signed-off-by: Shashank Ram <rams at vmware.com>
---
 datapath-windows/ovsext/PacketIO.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/datapath-windows/ovsext/PacketIO.c b/datapath-windows/ovsext/PacketIO.c
index a90b556..d82d25d 100644
--- a/datapath-windows/ovsext/PacketIO.c
+++ b/datapath-windows/ovsext/PacketIO.c
@@ -525,11 +525,11 @@ OvsCreateNewNBLsFromMultipleNBs(POVS_SWITCH_CONTEXT switchContext,
         }
         lastNbl->Next = *nextNbl;
         *nextNbl = newNbls->Next;
+        (*curNbl)->Next = NULL;
 
         OvsCompleteNBL(switchContext, *curNbl, TRUE);
 
         *curNbl = newNbls;
-        (*curNbl)->Next = NULL;
 
         error = FALSE;
     } while (error);
-- 
2.9.3.windows.2



More information about the dev mailing list