[ovs-dev] [PATCH 1/2] datapath: Avoid using stack larger than 1024.

[Joe Stringer]

On 2 July 2017 at 18:57, Tonghao Zhang <xiangxia.m.yue at gmail.com> wrote:
> Upstream commit:
>     commit 9cc9a5cb176ccb4f2cda5ac34da5a659926f125f
>     Author: Tonghao Zhang <xiangxia.m.yue at gmail.com>
>     Date:   Thu Jun 29 17:27:44 2017 -0700
>
>     datapath: Avoid using stack larger than 1024.
>
>     When compiling OvS-master on 4.4.0-81 kernel,
>     there is a warning:
>
>         CC [M]  /root/ovs/datapath/linux/datapath.o
>         /root/ovs/datapath/linux/datapath.c: In function
>         'ovs_flow_cmd_set':
>         /root/ovs/datapath/linux/datapath.c:1221:1: warning:
>         the frame size of 1040 bytes is larger than 1024 bytes
>         [-Wframe-larger-than=]
>
>     This patch factors out match-init and action-copy to avoid
>     "Wframe-larger-than=1024" warning. Because mask is only
>     used to get actions, we new a function to save some
>     stack space.
>
>     Signed-off-by: Tonghao Zhang <xiangxia.m.yue at gmail.com>
>     Acked-by: Pravin B Shelar <pshelar at ovn.org>
>     Signed-off-by: David S. Miller <davem at davemloft.net>
>
> Signed-off-by: Tonghao Zhang <xiangxia.m.yue at gmail.com>

Thanks for the backport!

I plan to roll this into a series that will bring the datapath pretty
much up to date, inserting in the same order as the upstream patches
were applied. I'll add my signoff and no further action should be
necessary from your part for this to land upstream to master.

Cheers,
Joe