[ovs-dev] [patch_v1 1/2] System Tests: Allow SNAT address variability retries.

Joe Stringer joe at ovn.org
Fri Jul 21 23:56:21 UTC 2017


On 21 July 2017 at 11:16, Joe Stringer <joe at ovn.org> wrote:
> On 21 July 2017 at 07:52, Darrell Ball <dball at vmware.com> wrote:
>>
>>
>> -----Original Message-----
>> From: Ilya Maximets <i.maximets at samsung.com>
>> Date: Friday, July 21, 2017 at 5:24 AM
>> To: Darrell Ball <dball at vmware.com>, Joe Stringer <joe at ovn.org>
>> Cc: ovs dev <dev at openvswitch.org>, Ben Pfaff <blp at ovn.org>
>> Subject: Re: [ovs-dev] [patch_v1 1/2] System Tests: Allow SNAT address variability retries.
>>
>>     On 21.07.2017 05:40, Darrell Ball wrote:
>>     > The discussion about the ‘Area’ prefix has come up again, even after Ben had commented about it
>>     > and after I had pointed folks to the submitting-patches.rst, which allows flexibility in choosing an
>>     > ‘Area’ prefix by the patch submitter.
>
> Hi Darrell,
>
> It seems like we got off on the wrong foot on this one. You had asked
> me to look at the patches, so I fetched them, looked at the somewhat
> trivial feedback, applied that locally and tested the patches. Given
> that it seemed like I had done all the work locally that you would
> have done if you respin a v2, I figured that I would propose to just
> push them as-is from my local tree. To be explicit about the changes I
> had made, I responded on the list to highlight the changes. This gave
> you a chance to review what I had done, which you have done. Clearly
> this topic is important enough to you that you preferred I don't apply
> the patches as I had prepared them - so I backed off to allow you to
> send a v2.

In the spirit of moving these useful patches past the bikeshed and
into master where we'll now see less frequent failures, I went ahead
and applied the v2 as-is.

Cheers,
Joe


More information about the dev mailing list