[ovs-dev] [PATCH 1/3] ofproto-dpif-rid: Include action length as part of hash.

Ben Pfaff blp at ovn.org
Thu Jul 27 20:54:22 UTC 2017


On Thu, Jul 13, 2017 at 11:30:49PM -0700, Justin Pettit wrote:
> Signed-off-by: Justin Pettit <jpettit at ovn.org>
> ---
>  ofproto/ofproto-dpif-rid.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/ofproto/ofproto-dpif-rid.c b/ofproto/ofproto-dpif-rid.c
> index d546b150b938..26c2357007b2 100644
> --- a/ofproto/ofproto-dpif-rid.c
> +++ b/ofproto/ofproto-dpif-rid.c
> @@ -146,6 +146,7 @@ frozen_state_hash(const struct frozen_state *state)
>          hash = hash_bytes64(ALIGNED_CAST(const uint64_t *, state->action_set),
>                              state->action_set_len, hash);
>      }
> +    hash = hash_int(state->ofpacts_len, hash);
>      if (state->ofpacts_len) {
>          hash = hash_bytes64(ALIGNED_CAST(const uint64_t *, state->ofpacts),
>                              state->ofpacts_len, hash);

Can you explain the benefit of this change?  hash_bytes64() already uses
the number of bytes hashed as one of the inputs to the hash.


More information about the dev mailing list