[ovs-dev] [PATCH 2/3] ofproto-dpif-rid: Store tunnel metadata in frozen metadata directly.

Justin Pettit jpettit at ovn.org
Fri Jul 28 05:28:48 UTC 2017

> On Jul 27, 2017, at 10:27 PM, Ben Pfaff <blp at ovn.org> wrote:
> On Thu, Jul 27, 2017 at 07:26:49PM -0700, Justin Pettit wrote:
>>> On Jul 27, 2017, at 4:24 PM, Ben Pfaff <blp at ovn.org> wrote:
>>> On Thu, Jul 13, 2017 at 11:30:50PM -0700, Justin Pettit wrote:
>>>> "recirc_id_node" contains a 'state_metadata_tunnel' member field.  The
>>>> "frozen_metadata" structure used by "recird_id_node" had a 'tunnel'
>>>> member that always pointed to 'state_metadata_tunnel".  This commit just
>>>> stores the tunnel information directly in "frozen_metadata" instead of
>>>> accessing it through a pointer.
>>>> Signed-off-by: Justin Pettit <jpettit at ovn.org>
>>> Would you mind adding something to the commit message to explain why
>>> this is a good thing?  I think I can guess, but rationale is important.
>>> Acked-by: Ben Pfaff <blp at ovn.org>
>> Thanks.  I pushed this to master with some added rationale.  I also
>> added the patch below to address some Travis errors when using an
>> older version of gcc.
> Sweet, I see that my suggestion worked ;-)

Nailed it.  Thanks!


More information about the dev mailing list