[ovs-dev] [PATCH] checkpatch: Fix typo for use as filter.

Aaron Conole aconole at redhat.com
Thu Jun 1 20:31:53 UTC 2017


Ben Pfaff <blp at ovn.org> writes:

> ovs_checkpatch_parse() takes 2 arguments, not sys.exit().  Oops.
>
> Fixes: 95bd35d3db19 ("checkpatch: Implement -f option more usefully.")
> Signed-off-by: Ben Pfaff <blp at ovn.org>
> ---

Weird.

  04:26:00 aconole {master} ~/git/ovs$ git log --grep="Implement -f" | grep Date:
  Date:   Fri May 26 11:22:36 2017 -0700
  04:26:01 aconole {master} ~/git/ovs$ rm flake8-check 
  04:26:07 aconole {master} ~/git/ovs$ make flake8-check >/dev/null && echo "WORKING"
  WORKING

Just tried doing an actual commit, instead of an am:

  Traceback (most recent call last):
    File "utilities/checkpatch.py", line 415, in <module>
      sys.exit(ovs_checkpatch_parse(sys.stdin.read()), '-')
  TypeError: ovs_checkpatch_parse() takes exactly 2 arguments (1 given)

:/

Sorry I missed it during my review.

Acked-by: Aaron Conole <aconole at redhat.com>


More information about the dev mailing list