[ovs-dev] [PATCH] dpif-netlink: Fix multiple-free and fd leak on error path.

Ben Pfaff blp at ovn.org
Thu Jun 1 23:42:27 UTC 2017


On Thu, Jun 01, 2017 at 04:26:01PM -0700, Justin Pettit wrote:
> 
> > On May 26, 2017, at 8:27 PM, Ben Pfaff <blp at ovn.org> wrote:
> > 
> > This function attempts to open a bunch of new handlers.  If it fails, it
> > attempts to close all the handlers that have already been opened.
> > Unfortunately, the loop to close the opened handlers used the wrong array
> > index: 'i' instead of 'j'.  This fixes the problem.
> > 
> > Found by Coverity.
> > 
> > Reported-at: https://scan3.coverity.com/reports.htm#v16889/p10449/fileInstanceId=14762827&defectInstanceId=4305351&mergedDefectId=180429
> > Signed-off-by: Ben Pfaff <blp at ovn.org>
> 
> Acked-by: Justin Pettit <jpettit at ovn.org>

Thanks, applied to master and backported as far as branch-2.4.


More information about the dev mailing list