[ovs-dev] [PATCH 2/2] ipfix: Update Timestamp when flow updated

Felix Konstantin Maurer felix.maurer at comsys.rwth-aachen.de
Wed Jun 7 07:23:54 UTC 2017


In case you know a little Go, here is my script to test my IPFIX setup.
I also use Wireshark which works quite well.
I'll look into it too, today.

Regards
Felix

On 06/06/2017 10:42 PM, Greg Rose wrote:
> On 06/06/2017 08:22 AM, Ben Pfaff wrote:
>> On Mon, Jun 05, 2017 at 08:34:32PM -0700, Greg Rose wrote:
>> > On 06/05/2017 06:04 PM, Ben Pfaff wrote:
>> >> From: Greg Rose <gvrose8192 at gmail.com>
>> >>
>> >> Reported-by: Felix Konstantin Maurer
>> <felix.maurer at comsys.rwth-aachen.de>
>> >> Signed-off-by: Greg Rose <gvrose8192 at gmail.com>
>> >> [blp at ovn.org changed this to use ipfix_now()]
>> >> Signed-off-by: Ben Pfaff <blp at ovn.org>
>> >> ---
>> >>   ofproto/ofproto-dpif-ipfix.c | 1 +
>> >>   1 file changed, 1 insertion(+)
>> >>
>> >> diff --git a/ofproto/ofproto-dpif-ipfix.c
>> b/ofproto/ofproto-dpif-ipfix.c
>> >> index 5589b0ea05e1..bc63b7b0294b 100644
>> >> --- a/ofproto/ofproto-dpif-ipfix.c
>> >> +++ b/ofproto/ofproto-dpif-ipfix.c
>> >> @@ -1643,6 +1643,7 @@ ipfix_cache_update(struct dpif_ipfix_exporter
>> *exporter,
>> >>           ipfix_cache_aggregate_entries(entry, old_entry);
>> >>           free(entry);
>> >>           ipfix_update_stats(exporter, false, current_flows,
>> sampled_pkt_type);
>> >> +        old_entry->flow_end_timestamp_usec = ipfix_now();
>> >>       }
>> >>   }
>> >>
>> >>
>> > Looks good, thanks Ben!
>>
>> Thanks for the review!
>>
>> If I recall correctly, Felix reported that your original patch didn't
>> help, though, so probably this one doesn't either.  We should track that
>> down before we go farther, I guess.
>>
> Yes, I'm am following up.  Having all sorts of problems getting a
> working ipfix flow collector to work though.  The ManageEngine netflow
> collector claims to work with ipfix but SFAICT it does not so I'm not
> going to waste more time on it.  Once I can start
> collecting and analyzing the work should proceed quickly.
> 
> Thanks,
> 
> - Greg

-- 
RWTH Aachen University
Communication and Distributed Systems
http://www.comsys.rwth-aachen.de


More information about the dev mailing list