[ovs-dev] [PATCH v2 1/3] windows: add definition of getpid and getcwd

[Alin Serdean]

> On Fri, May 19, 2017 at 11:16:16PM +0000, Alin Serdean wrote:
> > > >  #define WIN32_LEAN_AND_MEAN
> > > > +#include <config.h>
> > > >  #include <windows.h>
> > > > +#include <direct.h>
> > >
> > > Thanks for the revised patch.
> > >
> > > Does #include <config.h> make a difference?  Every .c file should
> > > already start out with that #include, and so if it makes a
> > > difference then it probably indicates that some .c file has
> > > forgotten it.  (But the Makefile checks for that, so it is
> > > unlikely.)
> > >
> > > Thanks,
> > >
> > > Ben.
> > [Alin Serdean] I did a clean compile and a run of unit tests and everything
> was ok.
> > I included <config.h> for
> https://github.com/openvswitch/ovs/blob/master/include/windows/windef
> s.h#L41 .
> > Should I change <config,h> to <windefs.h> ?
> 
> It looks like config.h always include windefs.h, on Windows.  Every .c file
> includes config.h.  Thus, there should be no need for anything else to ever
> include config.h or windefs.h.  Right?
[Alin Serdean] Yup, it makes total sense. I was a bit tired when I wrote the reply 😊.