[ovs-dev] [PATCH] netdev: Fix netdev_open() to adhere to class type if given

Ben Pfaff blp at ovn.org
Wed Jun 14 16:27:10 UTC 2017


On Wed, Jun 14, 2017 at 06:21:50PM +0200, Eelco Chaudron wrote:
> On 02/06/17 00:25, Ben Pfaff wrote:
> >On Thu, Jun 01, 2017 at 02:38:09PM +0200, Eelco Chaudron wrote:
> >>When trying to configure a system port as type=internal it could start
> >>an infinite port creation loop. When this happens you will see the
> >>following log messages:
> >...
> >>So the fix as presented below is causing netdev_open() only to return
> >>the existing device for the class type requested (if the type is
> >>specified).
> >I suspect that this will cause other, subtle, issues, that we will have
> >to track down later, related to devices that currently can be opened
> >under multiple different types.  However, I've applied it for now, and
> >if/when those issues come up, we can figure them out.
> >
> >Thanks a lot!
> >
> >Ben
> Can we get this also on the 2.7 branch?

OK.  If it causes problems, we'll need to fix them or revert it, of
course.


More information about the dev mailing list