[ovs-dev] [PATCH v2 12/12] work on packet aware test

Ben Pfaff blp at ovn.org
Sun Jun 18 23:29:41 UTC 2017


---
 tests/packet-type-aware.at | 247 ++++++++++++++++++++++-----------------------
 1 file changed, 118 insertions(+), 129 deletions(-)

diff --git a/tests/packet-type-aware.at b/tests/packet-type-aware.at
index 0aaeffab3211..25f7a7c9c204 100644
--- a/tests/packet-type-aware.at
+++ b/tests/packet-type-aware.at
@@ -33,10 +33,6 @@ AT_CLEANUP
 
 AT_SETUP([ptap - triangle bridge setup with L2 and L3 GRE tunnels])
 
-# Always skip this test, for now, until it is revised to use patch
-# ports in place of veth devices.
-AT_SKIP_IF([:])
-
 ########################
 # GRE tunneling test setup for PTAP bridge
 #
@@ -73,67 +69,75 @@ AT_SKIP_IF([:])
 #      3021   br-in1      gre-32_l3   l3                same
 
 
-OVS_VSWITCHD_START([])
+OVS_VSWITCHD_START([dnl
+    -- add-br br-in1 \
+    -- set bridge br-in1 datapath_type=dummy fail-mode=secure \
+    -- add-br br-in2 \
+    -- set bridge br-in2 datapath_type=dummy fail-mode=secure \
+    -- add-br br-in3 \
+    -- set bridge br-in3 datapath_type=dummy fail-mode=secure \
+    -- add-br br-p1 -- \
+    -- set bridge br-p1 datapath_type=dummy fail-mode=secure \
+    -- add-br br-p2 -- \
+    -- set bridge br-p2 datapath_type=dummy fail-mode=secure \
+    -- add-br br-p3 -- \
+    -- set bridge br-p3 datapath_type=dummy fail-mode=secure \
+    -- add-port br-p1 p1-0 \
+    -- set interface p1-0 type=patch options:peer=p1-1 ofport_request=2 \
+    -- add-port br-p2 p2-0 \
+    -- set interface p2-0 type=patch options:peer=p0-2 ofport_request=2 \
+    -- add-port br-p3 p3-0 \
+    -- set interface p3-0 type=patch options:peer=p0-3 ofport_request=2 \
+    -- add-port br0 p0-1 \
+    -- set interface p0-1 type=patch options:peer=p1-0 ofport_request=10 \
+    -- add-port br0 p0-2 \
+    -- set interface p0-2 type=patch options:peer=p2-0 ofport_request=20 \
+    -- add-port br0 p0-3 \
+    -- set interface p0-3 type=patch options:peer=p3-0 ofport_request=30 \
+    -- add-port br-in1 gre12 \
+    -- set interface gre12 type=gre options:remote_ip=10.0.0.2 \
+                           ofport_request=1020 \
+    -- add-port br-in1 gre12_l3 \
+    -- set interface gre12_l3 type=gre options:remote_ip=10.0.0.2 \
+                           ofport_request=1021 options:packet_type=legacy_l3 \
+    -- add-port br-in1 gre13 \
+    -- set interface gre13 type=gre options:remote_ip=10.0.0.3 \
+                                    ofport_request=1030 \
+    -- add-port br-in2 gre21 \
+    -- set interface gre21 type=gre options:remote_ip=20.0.0.1 \
+                           ofport_request=2010 \
+    -- add-port br-in2 gre23 \
+    -- set interface gre23 type=gre options:remote_ip=20.0.0.3 \
+                                    ofport_request=2030 \
+    -- add-port br-in3 gre31 \
+    -- set interface gre31 type=gre options:remote_ip=30.0.0.1 \
+                           ofport_request=3010 \
+    -- add-port br-in3 gre32 \
+    -- set interface gre32 type=gre options:remote_ip=30.0.0.2 \
+                           ofport_request=3020 \
+    -- add-port br-in3 gre32_l3 \
+    -- set interface gre32_l3 type=gre options:remote_ip=30.0.0.2 \
+                              ofport_request=3021 \
+			      options:packet_type=legacy_l3
+])
 
 HWADDR_BRP1=aa:55:00:00:00:01
 HWADDR_BRP2=aa:55:00:00:00:02
 HWADDR_BRP3=aa:55:00:00:00:03
 
-dnl Create veth ports to connect br0 with br-p1, br-p2 and br-p3
-AT_CHECK([ip link add p1-0 type veth peer name p0-1])
-AT_CHECK([ip link set p1-0 up])
-AT_CHECK([ip link set p0-1 up])
-AT_CHECK([ip link set dev p1-0 mtu 3300])
-AT_CHECK([ip link set dev p0-1 mtu 3300])
-on_exit 'ip link del p0-1'
-
-AT_CHECK([ip link add p2-0 type veth peer name p0-2])
-AT_CHECK([ip link set p2-0 up])
-AT_CHECK([ip link set p0-2 up])
-AT_CHECK([ip link set dev p2-0 mtu 3300])
-AT_CHECK([ip link set dev p0-2 mtu 3300])
-on_exit 'ip link del p0-2'
-
-AT_CHECK([ip link add p3-0 type veth peer name p0-3])
-AT_CHECK([ip link set p3-0 up])
-AT_CHECK([ip link set p0-3 up])
-AT_CHECK([ip link set dev p3-0 mtu 3300])
-AT_CHECK([ip link set dev p0-3 mtu 3300])
-on_exit 'ip link del p0-3'
-
 # Setup bridge infrastructure
 AT_CHECK([
-    ovs-vsctl add-br br-in1 -- \
-        set bridge br-in1 datapath_type=dummy fail-mode=standalone
-    ovs-vsctl add-br br-in2 -- \
-        set bridge br-in2 datapath_type=dummy fail-mode=standalone other-config:packet-type-aware=true
-    ovs-vsctl add-br br-in3 -- \
-        set bridge br-in3 datapath_type=dummy fail-mode=standalone
-    ovs-vsctl add-br br-p1 -- \
-        set bridge br-p1 datapath_type=dummy fail-mode=standalone other-config:hwaddr=$HWADDR_BRP1
-    ovs-vsctl add-br br-p2 -- \
-        set bridge br-p2 datapath_type=dummy fail-mode=standalone other-config:hwaddr=$HWADDR_BRP2
-    ovs-vsctl add-br br-p3 -- \
-        set bridge br-p3 datapath_type=dummy fail-mode=standalone other-config:hwaddr=$HWADDR_BRP3
-
-    ovs-vsctl add-port br-p1 p1-0 -- set interface p1-0 ofport_request=2
-    ovs-vsctl add-port br-p2 p2-0 -- set interface p2-0 ofport_request=2
-    ovs-vsctl add-port br-p3 p3-0 -- set interface p3-0 ofport_request=2
-    ovs-vsctl add-port br0 p0-1 -- set interface p0-1 ofport_request=10
-    ovs-vsctl add-port br0 p0-2 -- set interface p0-2 ofport_request=20
-    ovs-vsctl add-port br0 p0-3 -- set interface p0-3 ofport_request=30
-
     # Populate the MAC table of br0
-    ovs-ofctl del-flows br0
-    ovs-ofctl add-flow br0 dl_dst=$HWADDR_BRP1,actions=10
-    ovs-ofctl add-flow br0 dl_dst=$HWADDR_BRP2,actions=20
-    ovs-ofctl add-flow br0 dl_dst=$HWADDR_BRP3,actions=30
-
-    ovs-ofctl del-flows br-in1
-    ovs-ofctl del-flows br-in2
-    ovs-ofctl del-flows br-in3
-    ovs-ofctl del-flows br-p1
-    ovs-ofctl del-flows br-p2
+    ovs-ofctl del-flows br0 &&
+    ovs-ofctl add-flow br0 dl_dst=$HWADDR_BRP1,actions=10 &&
+    ovs-ofctl add-flow br0 dl_dst=$HWADDR_BRP2,actions=20 &&
+    ovs-ofctl add-flow br0 dl_dst=$HWADDR_BRP3,actions=30 &&
+
+    ovs-ofctl del-flows br-in1 &&
+    ovs-ofctl del-flows br-in2 &&
+    ovs-ofctl del-flows br-in3 &&
+    ovs-ofctl del-flows br-p1 &&
+    ovs-ofctl del-flows br-p2 &&
     ovs-ofctl del-flows br-p3
 ], [0])
 
@@ -144,43 +148,24 @@ AT_CHECK([
 
 ### Setup GRE tunnels
 AT_CHECK([
-    ovs-vsctl add-port br-in1 gre12 -- \
-        set interface gre12 type=gre options:remote_ip=10.0.0.2 ofport_request=1020
-    ovs-vsctl add-port br-in1 gre12_l3 -- \
-        set interface gre12_l3 type=gre options:remote_ip=10.0.0.2 ofport_request=1021 options:layer3=true
-    ovs-vsctl add-port br-in1 gre13 -- \
-        set interface gre13 type=gre options:remote_ip=10.0.0.3 ofport_request=1030
-
-    ovs-vsctl add-port br-in2 gre21 -- \
-        set interface gre21 type=gre options:remote_ip=20.0.0.1 ofport_request=2010
-    ovs-vsctl add-port br-in2 gre23 -- \
-        set interface gre23 type=gre options:remote_ip=20.0.0.3 ofport_request=2030
-
-    ovs-vsctl add-port br-in3 gre31 -- \
-        set interface gre31 type=gre options:remote_ip=30.0.0.1 ofport_request=3010
-    ovs-vsctl add-port br-in3 gre32 -- \
-        set interface gre32 type=gre options:remote_ip=30.0.0.2 ofport_request=3020
-    ovs-vsctl add-port br-in3 gre32_l3 -- \
-        set interface gre32_l3 type=gre options:remote_ip=30.0.0.2 ofport_request=3021 options:layer3=true
-
-    ovs-appctl netdev-dummy/ip4addr br-p1 10.0.0.1/24
-    ovs-appctl ovs/route/add 10.0.0.0/24 br-p1
-    ovs-appctl tnl/arp/set br-p1 10.0.0.1 $HWADDR_BRP1
-    ovs-appctl tnl/arp/set br-p1 10.0.0.2 $HWADDR_BRP2
-    ovs-appctl tnl/arp/set br-p1 10.0.0.3 $HWADDR_BRP3
-
-    ovs-appctl netdev-dummy/ip4addr br-p2 20.0.0.2/24
-    ovs-appctl ovs/route/add 20.0.0.0/24 br-p2
-    ovs-appctl tnl/arp/set br-p2 20.0.0.1 $HWADDR_BRP1
-    ovs-appctl tnl/arp/set br-p2 20.0.0.2 $HWADDR_BRP2
-    ovs-appctl tnl/arp/set br-p2 20.0.0.3 $HWADDR_BRP3
-
-    ovs-appctl netdev-dummy/ip4addr br-p3 30.0.0.3/24
-    ovs-appctl ovs/route/add 30.0.0.0/24 br-p3
-    ovs-appctl tnl/arp/set br-p3 30.0.0.1 $HWADDR_BRP1
-    ovs-appctl tnl/arp/set br-p3 30.0.0.2 $HWADDR_BRP2
+    ovs-appctl netdev-dummy/ip4addr br-p1 10.0.0.1/24 &&
+    ovs-appctl ovs/route/add 10.0.0.0/24 br-p1 &&
+    ovs-appctl tnl/arp/set br-p1 10.0.0.1 $HWADDR_BRP1 &&
+    ovs-appctl tnl/arp/set br-p1 10.0.0.2 $HWADDR_BRP2 &&
+    ovs-appctl tnl/arp/set br-p1 10.0.0.3 $HWADDR_BRP3 &&
+
+    ovs-appctl netdev-dummy/ip4addr br-p2 20.0.0.2/24 &&
+    ovs-appctl ovs/route/add 20.0.0.0/24 br-p2 &&
+    ovs-appctl tnl/arp/set br-p2 20.0.0.1 $HWADDR_BRP1 &&
+    ovs-appctl tnl/arp/set br-p2 20.0.0.2 $HWADDR_BRP2 &&
+    ovs-appctl tnl/arp/set br-p2 20.0.0.3 $HWADDR_BRP3 &&
+
+    ovs-appctl netdev-dummy/ip4addr br-p3 30.0.0.3/24 &&
+    ovs-appctl ovs/route/add 30.0.0.0/24 br-p3 &&
+    ovs-appctl tnl/arp/set br-p3 30.0.0.1 $HWADDR_BRP1 &&
+    ovs-appctl tnl/arp/set br-p3 30.0.0.2 $HWADDR_BRP2 &&
     ovs-appctl tnl/arp/set br-p3 30.0.0.3 $HWADDR_BRP3
-], [0], [stdout])
+], [0], [ignore])
 
 AT_CHECK([
     ovs-appctl ovs/route/show | grep User:
@@ -192,7 +177,7 @@ User: 30.0.0.0/24 dev br-p3 SRC 30.0.0.3
 
 AT_CHECK([
     ovs-appctl tnl/neigh/show | grep br-p | sort
-], [0], [stdout])
+], [0], [ignore])
 
 ### Flows in br-p<x>to twist TEP IP addresses in tunnel IP headers
 AT_CHECK([
@@ -237,12 +222,16 @@ N2_OFPORT=20
 N3_OFPORT=30
 
 AT_CHECK([
-    ovs-vsctl add-port br-in1 n1 -- \
-        set interface n1 type=dummy ofport_request=$N1_OFPORT options:tx_pcap=n1.pcap
-    ovs-vsctl add-port br-in2 n2 -- \
-        set interface n2 type=dummy ofport_request=$N2_OFPORT options:tx_pcap=n2.pcap
-    ovs-vsctl add-port br-in3 n3 -- \
-        set interface n3 type=dummy ofport_request=$N3_OFPORT options:tx_pcap=n3.pcap
+ovs-vsctl \
+    -- add-port br-in1 n1 \
+    -- set interface n1 type=dummy ofport_request=$N1_OFPORT \
+                                   options:tx_pcap=n1.pcap \
+    -- add-port br-in2 n2 \
+    -- set interface n2 type=dummy ofport_request=$N2_OFPORT \
+	                           options:tx_pcap=n2.pcap \
+    -- add-port br-in3 n3 \
+    -- set interface n3 type=dummy ofport_request=$N3_OFPORT \
+       	                           options:tx_pcap=n3.pcap
 ], [0])
 
 #N1_DPPORT=$(ovs-appctl dpif/show | grep "n1 10" | sed 's|.*/\([[0-9]]*\):.*|\1|')
@@ -251,39 +240,39 @@ AT_CHECK([
 
 ### Verify datapath configuration
 AT_CHECK([
-    ovs-appctl dpif/show | grep -v hit | sed 's/\t/    /g'
+    ovs-appctl dpif/show | grep -v hit | sed 's/\t/    /g' | sed 's./[[0-9]]\{1,\}..'
 ], [0], [dnl
     br-in1:
-        br-in1 65534/101: (dummy-internal)
-        gre12 1020/10: (gre: remote_ip=10.0.0.2)
-        gre12_l3 1021/10: (gre: layer3=true, remote_ip=10.0.0.2)
-        gre13 1030/10: (gre: remote_ip=10.0.0.3)
-        n1 10/11: (dummy)
+        br-in1 65534: (dummy-internal)
+        gre12 1020: (gre: remote_ip=10.0.0.2)
+        gre12_l3 1021: (gre: packet_type=legacy_l3, remote_ip=10.0.0.2)
+        gre13 1030: (gre: remote_ip=10.0.0.3)
+        n1 10: (dummy)
     br-in2:
-        br-in2 65534/102: (dummy-internal)
-        gre21 2010/10: (gre: remote_ip=20.0.0.1)
-        gre23 2030/10: (gre: remote_ip=20.0.0.3)
-        n2 20/12: (dummy)
+        br-in2 65534: (dummy-internal)
+        gre21 2010: (gre: remote_ip=20.0.0.1)
+        gre23 2030: (gre: remote_ip=20.0.0.3)
+        n2 20: (dummy)
     br-in3:
-        br-in3 65534/103: (dummy-internal)
-        gre31 3010/10: (gre: remote_ip=30.0.0.1)
-        gre32 3020/10: (gre: remote_ip=30.0.0.2)
-        gre32_l3 3021/10: (gre: layer3=true, remote_ip=30.0.0.2)
-        n3 30/13: (dummy)
+        br-in3 65534: (dummy-internal)
+        gre31 3010: (gre: remote_ip=30.0.0.1)
+        gre32 3020: (gre: remote_ip=30.0.0.2)
+        gre32_l3 3021: (gre: packet_type=legacy_l3, remote_ip=30.0.0.2)
+        n3 30: (dummy)
     br-p1:
-        br-p1 65534/1: (dummy-internal)
-        p1-0 2/4: (system)
+        br-p1 65534: (dummy-internal)
+        p1-0 2/none: (patch: peer=p1-1)
     br-p2:
-        br-p2 65534/2: (dummy-internal)
-        p2-0 2/5: (system)
+        br-p2 65534: (dummy-internal)
+        p2-0 2/none: (patch: peer=p0-2)
     br-p3:
-        br-p3 65534/3: (dummy-internal)
-        p3-0 2/6: (system)
+        br-p3 65534: (dummy-internal)
+        p3-0 2/none: (patch: peer=p0-3)
     br0:
-        br0 65534/100: (dummy-internal)
-        p0-1 10/7: (system)
-        p0-2 20/8: (system)
-        p0-3 30/9: (system)
+        br0 65534: (dummy-internal)
+        p0-1 10/none: (patch: peer=p1-0)
+        p0-2 20/none: (patch: peer=p2-0)
+        p0-3 30/none: (patch: peer=p3-0)
 ])
 
 ### Test L3 forwarding flows
@@ -314,9 +303,9 @@ AT_CHECK([
 AT_CHECK([
     ovs-ofctl dump-flows br-in2 | ofctl_strip | sort | grep actions
 ], [0], [dnl
- packet_type=(0,0),ip,nw_dst=192.168.10.10 actions=output:2010
- packet_type=(0,0),ip,nw_dst=192.168.10.20 actions=mod_dl_dst:aa:55:aa:55:00:02,output:20
- packet_type=(0,0),ip,nw_dst=192.168.10.30 actions=output:2010
+ ip,nw_dst=192.168.10.10 actions=output:2010
+ ip,nw_dst=192.168.10.20 actions=mod_dl_dst:aa:55:aa:55:00:02,output:20
+ ip,nw_dst=192.168.10.30 actions=output:2010
  packet_type=(1,0x800),nw_dst=192.168.10.10 actions=output:2010
  packet_type=(1,0x800),nw_dst=192.168.10.30 actions=output:2030
 ])
@@ -340,7 +329,7 @@ AT_CHECK([
 ovs-appctl time/warp 1000
 
 AT_CHECK([
-    ovs-appctl dpctl/dump-flows dummy at ovs-dummy | strip_used | grep -v ipv6 | sort
+    ovs-appctl dpctl/dump-flows --names dummy at ovs-dummy | strip_used | grep -v ipv6 | sort
 ], [0], [flow-dump from non-dpdk interfaces:
 recirc_id(0),in_port(1),eth_type(0x0800),ipv4(frag=no), packets:1, bytes:136, used:0.0s, actions:4
 recirc_id(0),in_port(11),eth_type(0x0800),ipv4(dst=192.168.10.30,tos=0/0x3,frag=no), packets:1, bytes:98, used:0.0s, actions:tnl_push(tnl_port(10),header(size=38,type=3,eth(dst=aa:55:00:00:00:03,src=aa:55:00:00:00:01,dl_type=0x0800),ipv4(src=10.0.0.1,dst=10.0.0.3,proto=47,tos=0,ttl=64,frag=0x4000),gre((flags=0x0,proto=0x6558))),out_port(1))
-- 
2.10.2



More information about the dev mailing list