[ovs-dev] [PATCH v2 00/12] Packet type aware pipeline
Jan Scheurich
jan.scheurich at ericsson.com
Mon Jun 19 14:29:47 UTC 2017
Thanks, Ben, for the updated series.
I suggest to decouple the port name related patches.
We will test and review the remaining patches and have a look at the PTAP unit tests and provide fixes to the test (or bugfixes to the code).
BR, Jan
> -----Original Message-----
> From: ovs-dev-bounces at openvswitch.org [mailto:ovs-dev-bounces at openvswitch.org] On Behalf Of Ben Pfaff
> Sent: Monday, 19 June, 2017 01:29
> To: dev at openvswitch.org
> Cc: Ben Pfaff <blp at ovn.org>
> Subject: [ovs-dev] [PATCH v2 00/12] Packet type aware pipeline
>
> This series is based on Zoltan Balogh's series here:
> https://patchwork.ozlabs.org/patch/770490/
> https://patchwork.ozlabs.org/patch/770487/
> https://patchwork.ozlabs.org/patch/770495/
> https://patchwork.ozlabs.org/patch/770498/
> https://patchwork.ozlabs.org/patch/770488/
> https://patchwork.ozlabs.org/patch/770489/
>
> v1->v2:
> - Squash fixup patches.
> - Apply changes agreed with Jan.
> - Not yet done: Figure out whether to really show packet_type in (some)
> match_format() output.
> - New patch at the end unsuccessfully tries to re-enable packet-aware
> test. Either I don't have enough insight yet, or it just reveals a
> bug or two.
> - 4 new patches at beginning. First one is trivial. Next 3 are intended
> to make it easier to debug the packet aware test that is still failing.
> Jan, you don't have to feel obligated to review these if you feel they
> are off-topic; I will get separate reviews.
>
> Ben Pfaff (8):
> ofp-util: Remove prototype for unimplemented function.
> openvswitch.h: Use odp_port_t for port numbers in userspace-only
> structs.
> ovs-dpctl: New --names option to use port names in flow dumps.
> odp-util: Use port names in output in more places.
> ofpbuf: New function ofpbuf_insert().
> nx-match: Add context argument to nxm_put__().
> userspace: Handling of versatile tunnel ports
> work on packet aware test
>
> Jan Scheurich (3):
> userspace: Add OXM field MFF_PACKET_TYPE
> tests: Added unit tests in packet-type-aware.at
> userspace: Complete Packet In handling
>
> Zoltán Balogh (1):
> userspace: Introduce packet_type in OF 1.5 packet-out
>
> NEWS | 6 +-
> build-aux/extract-ofp-fields | 3 +-
> datapath/linux/compat/include/linux/openvswitch.h | 4 +-
> include/openvswitch/match.h | 5 +
> include/openvswitch/meta-flow.h | 20 +
> include/openvswitch/ofp-util.h | 2 -
> include/openvswitch/ofpbuf.h | 1 +
> lib/dpctl.c | 84 ++--
> lib/dpctl.h | 3 +
> lib/dpctl.man | 7 +-
> lib/dpif-netdev.c | 4 +-
> lib/dpif.c | 4 +-
> lib/flow.c | 74 +++-
> lib/flow.h | 27 +-
> lib/learn.c | 1 +
> lib/match.c | 98 +++--
> lib/meta-flow.c | 86 +++-
> lib/meta-flow.xml | 154 ++++++-
> lib/netdev-bsd.c | 1 +
> lib/netdev-dpdk.c | 1 +
> lib/netdev-dummy.c | 1 +
> lib/netdev-linux.c | 1 +
> lib/netdev-native-tnl.c | 23 +-
> lib/netdev-provider.h | 6 +
> lib/netdev-vport.c | 106 +++--
> lib/netdev-vport.h | 1 -
> lib/netdev.c | 10 +-
> lib/netdev.h | 29 +-
> lib/nx-match.c | 264 +++++++-----
> lib/nx-match.h | 6 +-
> lib/odp-util.c | 138 +++---
> lib/odp-util.h | 5 +-
> lib/ofp-parse.c | 25 ++
> lib/ofp-print.c | 11 +-
> lib/ofp-util.c | 69 ++-
> lib/ofpbuf.c | 18 +
> lib/tun-metadata.c | 4 +-
> ofproto/ofproto-dpif-sflow.c | 2 +-
> ofproto/ofproto-dpif-trace.c | 2 +-
> ofproto/ofproto-dpif-xlate.c | 45 +-
> ofproto/ofproto-dpif.c | 54 ++-
> ofproto/ofproto.c | 3 +
> ofproto/tunnel.c | 29 +-
> tests/automake.mk | 6 +-
> tests/dpif-netdev.at | 89 ++--
> tests/odp.at | 1 +
> tests/ofproto-dpif.at | 230 +++++-----
> tests/ofproto.at | 86 ++++
> tests/ovs-ofctl.at | 2 +-
> tests/packet-type-aware.at | 484 ++++++++++++++++++++++
> tests/pmd.at | 8 +-
> tests/system-userspace-packet-type-aware.at | 422 +++++++++++++++++++
> tests/system-userspace-testsuite.at | 1 +
> tests/test-odp.c | 2 +-
> tests/testsuite.at | 1 +
> tests/tunnel-push-pop-ipv6.at | 6 +-
> tests/tunnel-push-pop.at | 6 +-
> tests/tunnel.at | 18 +-
> utilities/ovs-dpctl.8.in | 9 +-
> utilities/ovs-dpctl.c | 20 +
> utilities/ovs-ofctl.c | 1 +
> vswitchd/vswitch.xml | 94 ++++-
> 62 files changed, 2315 insertions(+), 608 deletions(-)
> create mode 100644 tests/packet-type-aware.at
> create mode 100644 tests/system-userspace-packet-type-aware.at
>
> --
> 2.10.2
>
> _______________________________________________
> dev mailing list
> dev at openvswitch.org
> https://mail.openvswitch.org/mailman/listinfo/ovs-dev
More information about the dev
mailing list