[ovs-dev] [PATCH 4/6] dpif-netlink-rtnl: Fix dead store reported by clang.

Bhanuprakash Bodireddy bhanuprakash.bodireddy at intel.com
Mon Jun 19 18:54:02 UTC 2017


Clang reports variable 'ifmsg' never been used in the function.

Signed-off-by: Bhanuprakash Bodireddy <bhanuprakash.bodireddy at intel.com>
---
 lib/dpif-netlink-rtnl.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/lib/dpif-netlink-rtnl.c b/lib/dpif-netlink-rtnl.c
index c3c31eb..17ae24a 100644
--- a/lib/dpif-netlink-rtnl.c
+++ b/lib/dpif-netlink-rtnl.c
@@ -140,11 +140,9 @@ rtnl_policy_parse(const char *kind, struct ofpbuf *reply,
 {
     struct nlattr *linkinfo[ARRAY_SIZE(linkinfo_policy)];
     struct nlattr *rtlink[ARRAY_SIZE(rtlink_policy)];
-    struct ifinfomsg *ifmsg;
     int error = 0;
 
-    ifmsg = ofpbuf_at(reply, NLMSG_HDRLEN, sizeof *ifmsg);
-    if (!nl_policy_parse(reply, NLMSG_HDRLEN + sizeof *ifmsg,
+    if (!nl_policy_parse(reply, NLMSG_HDRLEN + sizeof(struct ifinfomsg),
                          rtlink_policy, rtlink, ARRAY_SIZE(rtlink_policy))
         || !nl_parse_nested(rtlink[IFLA_LINKINFO], linkinfo_policy,
                             linkinfo, ARRAY_SIZE(linkinfo_policy))
-- 
2.4.11



More information about the dev mailing list