[ovs-dev] [PATCH v1 4/6] ovn util: Refactor dhcp_opts_map to make it generic

Numan Siddique nusiddiq at redhat.com
Tue Jun 20 04:59:21 UTC 2017


On Fri, Jun 16, 2017 at 7:42 PM, Brian Haley <haleyb.dev at gmail.com> wrote:

> On 06/15/2017 04:39 AM, nusiddiq at redhat.com wrote:
>
>> From: Numan Siddique <nusiddiq at redhat.com>
>>
>> Renamed 'struct dhcp_opts_map' to 'struct gen_opts_map' and
>> renamed ovn-dhcp.h to ovn-l7.h. An upcoming commit to support IPv6
>> Router Advertisement, will make use of the refactored code to store
>> the IPv6 ND RA options in 'struct gen_opts_map'.
>>
>
> <snip>
>
> @@ -233,16 +233,16 @@ struct ovnact_put_mac_bind {
>>       struct expr_field mac;      /* 48-bit Ethernet address. */
>>   };
>>   -struct ovnact_dhcp_option {
>> -    const struct dhcp_opts_map *option;
>> +struct ovnact_gen_option {
>> +    const struct gen_opts_map *option;
>>       struct expr_constant_set value;
>>   };
>>     /* OVNACT_PUT_DHCPV4_OPTS, OVNACT_PUT_DHCPV6_OPTS. */
>
>
> Super-nit: guess this comment should change here or in patch 5/6,
> otherwise looks good.


Thanks Brian for the review. I think it should change in patch 5 to also
include OVNACT_PUT_ND_RA_OPTS. I will incorporate it in my next patch set.

Numan


>
>
> -struct ovnact_put_dhcp_opts {
>> +struct ovnact_put_opts {
>>       struct ovnact ovnact;
>>       struct expr_field dst;      /* 1-bit destination field. */
>> -    struct ovnact_dhcp_option *options;
>> +    struct ovnact_gen_option *options;
>>       size_t n_options;
>>   };
>>
>
> -Brian
>


More information about the dev mailing list