[ovs-dev] [PATCH] tests: switch from signed to unsigned when formatting

Guru Shetty guru at ovn.org
Thu Jun 22 01:53:18 UTC 2017


On 20 June 2017 at 12:44, Alin Serdean <aserdean at cloudbasesolutions.com>
wrote:

> x->errline is a signed int
> (https://github.com/openvswitch/ovs/blob/934386dd129a3f15b2546562a775f2
> f43dd3aac6/tests/test-sflow.c#L88)
> Flagged by static code analysis.
>
> Signed-off-by: Alin Gabriel Serdean <aserdean at cloudbasesolutions.com>
>
Applied, thanks!


> ---
>  tests/test-sflow.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/test-sflow.c b/tests/test-sflow.c
> index 6125d38..039a1b1 100644
> --- a/tests/test-sflow.c
> +++ b/tests/test-sflow.c
> @@ -675,7 +675,7 @@ print_sflow(struct ofpbuf *buf)
>          process_datagram(x);
>      } else {
>          // CATCH
> -        printf("\n>>>>> ERROR in " __FILE__ " at line %u\n", x->errline);
> +        printf("\n>>>>> ERROR in " __FILE__ " at line %d\n", x->errline);
>      }
>  }
>
> --
> 2.10.2.windows.1
> _______________________________________________
> dev mailing list
> dev at openvswitch.org
> https://mail.openvswitch.org/mailman/listinfo/ovs-dev
>


More information about the dev mailing list