[ovs-dev] [PATCH] rhel-systemd: start vswitchd after udev

Aaron Conole aconole at redhat.com
Thu Jun 29 20:24:43 UTC 2017


Russell Bryant <russell at ovn.org> writes:

> On Mon, May 29, 2017 at 7:30 AM, Karthik Sundaravel <ksundara at redhat.com> wrote:
>> Hi
>>
>> Tested-by: ksundara at redhat.com
>> I've tested the patch. Please see https://bugzilla.redhat.
>> com/show_bug.cgi?id=1397299#c17.
>
> Thanks for testing and reporting back!
>
> Sorry for the slow review.

Still not the longest I've had to wait for a bugfix, so no problems :)

> I've applied this to master and branch-2.7.

Great!  Thanks, Russell!

>>
>> Regards
>> Karthik S
>>
>> On Fri, May 19, 2017 at 3:21 AM, Ben Pfaff <blp at ovn.org> wrote:
>>
>>> On Thu, May 18, 2017 at 05:11:03PM -0400, Aaron Conole wrote:
>>> > Ben Pfaff <blp at ovn.org> writes:
>>> >
>>> > > On Sat, May 13, 2017 at 11:08:13AM -0400, Aaron Conole wrote:
>>> > >> Aaron Conole writes:
>>> > >> > It's possible to race with the udev service, such that dpdk ports
>>> are
>>> > >> > not finished being bound until after ovs-vswitchd has been started.
>>> > >> > This means that attempts to use the port will fail.  While it is
>>> > >> > possible to work around this for some NICs using port hotplug, not
>>> all
>>> > >> > port types are supported (for instance vfio), and it requires manual
>>> > >> > intervention.
>>> > >> >
>>> > >> > Fixes: 36af136b690c ("rhel-systemd: Delay shutting down the
>>> services")
>>> > >> > Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=1397299
>>> > >> > Suggested-by: Flavio Leitner <fbl at sysclose.org>
>>> > >> > Signed-off-by: Aaron Conole <aconole at redhat.com>
>>>
>> Tested-by: ksundara at redhat.com
>>
>>> > >> > ---
>>> > >> >  rhel/usr_lib_systemd_system_ovs-vswitchd.service | 2 +-
>>> > >> >  1 file changed, 1 insertion(+), 1 deletion(-)
>>> > >>
>>> > >> Ping?  Should I rebase / resend this?  I'm not sure if it still
>>> applies
>>> > >> to the tree.
>>> > >
>>> > > It still applies fine but I'm not comfortable reviewing it myself.  Is
>>> > > Flavio the right one to review it or should someone else?
>>> >
>>> > Flavio had actually suggested it.  I'm CC'ing the tester.  Maybe we can
>>> > at least get a Tested-by tag.
>>>
>>> I didn't realize there was a tester.  I guess that I should have looked
>>> at the bugzilla URL.
>>>
>>> If Maxim tested it successfully, we don't really need him to give us the
>>> Tested-by, we can add it ourselves.  (But now that we've asked, we might
>>> as well get an answer.)
>>>
>>> Thanks,
>>>
>>> Ben.
>>> _______________________________________________
>>> dev mailing list
>>> dev at openvswitch.org
>>> https://mail.openvswitch.org/mailman/listinfo/ovs-dev
>>>
>> _______________________________________________
>> dev mailing list
>> dev at openvswitch.org
>> https://mail.openvswitch.org/mailman/listinfo/ovs-dev


More information about the dev mailing list