[ovs-dev] [PATCH v3 00/16] port Jiri Benc's L3 patchset to ovs

Joe Stringer joe at ovn.org
Thu Mar 2 19:56:44 UTC 2017


Thanks for looking it over, that sounds reasonable. I'll be looking
forward along the other backports to try to get us back in better sync
with upstream.

I will mention that at this stage, the tree that I pointed to is
missing the MPLS GSO backport but everything else should be up to date
until the end of the L3 tunnelling series. I'll follow up on the MPLS
GSO thread regarding that[0].

[0] http://patchwork.ozlabs.org/patch/725891/

On 1 March 2017 at 20:23, Yang, Yi Y <yi.y.yang at intel.com> wrote:
> Joe, I checked this tree https://github.com/joestringer/openvswitch/commits/dev/backport_review_v0.6 , it included all the 802.1ad patches and Jiri's l3 kernel data path patches, so I think this is the first step we should take, once they are officially merged, Jan and I will rework userspace l3 patches and vxlangpe patches and resubmit them based on your tree.
>
> -----Original Message-----
> From: Joe Stringer [mailto:joe at ovn.org]
> Sent: Thursday, March 2, 2017 11:43 AM
> To: Yang, Yi Y <yi.y.yang at intel.com>
> Cc: ovs dev <dev at openvswitch.org>; Jarno Rajahalme <jarno at ovn.org>
> Subject: Re: [ovs-dev] [PATCH v3 00/16] port Jiri Benc's L3 patchset to ovs
>
> On 6 February 2017 at 05:04, Yi Yang <yi.y.yang at intel.com> wrote:
>> This patch set just ports Jiri Benc's L3 8 support patches for layer 3 encapsulated packets from net-next to current ovs, it also includes Jiri Benc's 3 userspace patches, Jarno Rajahalme and Pravin Shelar's vlan fix patches for L3 patchset as well as my 3 patches which enabled vxlangpe in compat mode and dpdk netdev in both L2 and L3(layer3=true) mode.
>>
>> This patchset has been verified on Ubuntu 14.04 x86_64 with Linux kernel 3.13.0-24-generic and 4.9.7, it also passed "make check"
>> and "sudo make check-kmod RECHECK=yes" in Fedora 23 with kernel
>> 4.2.3-300.fc23.x86_64
>>
>> This patch set is based on https://mail.openvswitch.org/pipermail/ovs-dev/2017-February/328492.html ([PATCH v2 0/4] Backport 802.1ad patches), please merge this one after merging [PATCH v2 0/4] Backport 802.1ad patches.
>>
>> Yi Yang (16):
>>   datapath: use hard_header_len instead of hardcoded ETH_HLEN
>>   datapath: add mac_proto field to the flow key
>>   datapath: pass mac_proto to ovs_vport_send
>>   datapath: support MPLS push and pop for L3 packets
>>   datapath: add processing of L3 packets
>>   datapath: netlink: support L3 packets
>>   datapath: add Ethernet push and pop actions
>>   datapath: allow L3 netdev ports
>>   userspace: add support for pop_eth and push_eth actions
>>   userspace: add layer 3 flow and switching support
>>   userspace: add non-tap (l3) support to GRE vports
>>   datapath: Add a missing break statement
>>   datapath: upcall: Fix vlan handling.
>>   datapath: enable vxlangpe creation in compat mode
>>   userspace: enable layer3 option for vxlan-gpe
>>   userspace: add vxlan-gpe support for dpdk netdev
>
> Picking this thread back up, apologies for the delay..
>
> Given that these backports + vlan + other series by Jarno may be interdependent on each other, I figured that I will assemble a single tree that brings them all together, run travis and local kmod testing on a variety of platforms, as well as per-commit compile checks with kernels 4.9 and 3.13.
>
> Here's the current tree I'm testing:
> https://github.com/joestringer/openvswitch/commits/dev/backport_review_v0.6
>
> Travis looks good (build check against a range of kernels):
> https://travis-ci.org/joestringer/openvswitch/builds/206841787
>
> My local system-kmod testing on a variety of platforms is coming out looking good so far.
>
> I dropped the userspace changes since they are decoupled and superseded. Where they were necessary to fix the build, I folded in the minimal changes necessary to fix the patch so that the tree successfully compiles on each individual commit.
>
> I'd appreciate if you could look over that tree once more, there's a couple of new patches that I backported but otherwise it's all series that have been out on the mailinglist over the past few weeks. I folded a few fixes together so that the tree should not break in between commits. I also updated the formatting of each commit message to unsure that, for example, attribution is retained from the original commits. Given they're building fine and testing looks good, I'd like to move towards pushing these patches, and then I can continue with the next series of backports review.
>
> New commits:
> https://github.com/joestringer/openvswitch/commit/8fa9841b9b06139f69f0138868ed9d6df730b748
> https://github.com/joestringer/openvswitch/commit/c598981830e1274391fb80bae6ca9862e6c53fda
>
> Where I made changes to the posted patches, I updated the commit message to include [Committer notes].


More information about the dev mailing list