[ovs-dev] [PATCH v2 01/22] datapath: make ndo_get_stats64 a void function

Joe Stringer joe at ovn.org
Fri Mar 3 22:52:13 UTC 2017


On 28 February 2017 at 17:17, Jarno Rajahalme <jarno at ovn.org> wrote:
> From: stephen hemminger <stephen at networkplumber.org>
>
> Upstream commit:
>
>     commit bc1f44709cf27fb2a5766cadafe7e2ad5e9cb221
>     Author: stephen hemminger <stephen at networkplumber.org>
>     Date:   Fri Jan 6 19:12:52 2017 -0800
>
>     net: make ndo_get_stats64 a void function
>
>     The network device operation for reading statistics is only called
>     in one place, and it ignores the return value. Having a structure
>     return value is potentially confusing because some future driver could
>     incorrectly assume that the return value was used.
>
>     Fix all drivers with ndo_get_stats64 to have a void function.
>
>     Signed-off-by: Stephen Hemminger <sthemmin at microsoft.com>
>     Signed-off-by: David S. Miller <davem at davemloft.net>
>
> This seems to be fine for all prior Linux versions as well.
>
> Signed-off-by: Jarno Rajahalme <jarno at ovn.org>

Since this particular patch came before my intermediate backport
series[0], I applied it before applying that series. Thanks!

[0] https://mail.openvswitch.org/pipermail/ovs-dev/2017-March/329288.html


More information about the dev mailing list