[ovs-dev] [PATCH v2 21/22] tests: Add an FTP test without conntrack.

[Joe Stringer]

On 28 February 2017 at 17:17, Jarno Rajahalme <jarno at ovn.org> wrote:
> If FTP tests with conntrack fail, it is informative to know if the
> problem is with the FTP client and/or server, or with conntrack
> itself.
>
> Signed-off-by: Jarno Rajahalme <jarno at ovn.org>
> ---
>  tests/system-traffic.at | 29 +++++++++++++++++++++++++++++
>  1 file changed, 29 insertions(+)
>
> diff --git a/tests/system-traffic.at b/tests/system-traffic.at
> index ac9f989..1cc41b7 100644
> --- a/tests/system-traffic.at
> +++ b/tests/system-traffic.at
> @@ -2040,6 +2040,35 @@ tcp,orig=(src=10.1.1.1,dst=10.1.1.2,sport=<cleared>,dport=<cleared>),reply=(src=
>  OVS_TRAFFIC_VSWITCHD_STOP
>  AT_CLEANUP
>
> +AT_SETUP([FTP - no conntrack])
> +AT_SKIP_IF([test $HAVE_PYFTPDLIB = no])

I suspect that this was updated since you wrote this test, the other tests use:

AT_SKIP_IF([test $HAVE_FTP = no])

Otherwise,

Acked-by: Joe Stringer <joe at ovn.org>