[ovs-dev] [PATCH 1/2] checkpatch: Check for pointer whitespace.

Russell Bryant russell at ovn.org
Wed Mar 8 19:23:58 UTC 2017


On Wed, Mar 8, 2017 at 12:54 PM, Joe Stringer <joe at ovn.org> wrote:
> Signed-off-by: Joe Stringer <joe at ovn.org>
> ---
>  utilities/checkpatch.py | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)
>
> diff --git a/utilities/checkpatch.py b/utilities/checkpatch.py
> index 26eb5c32b9bc..e795646de4a8 100755
> --- a/utilities/checkpatch.py
> +++ b/utilities/checkpatch.py
> @@ -68,6 +68,7 @@ __regex_is_for_if_single_line_bracket = \
>      re.compile(r'^ +(if|for|while) \(.*\)')
>  __regex_ends_with_bracket = \
>      re.compile(r'[^\s]\) {(\s+/\*[\s\Sa-zA-Z0-9\.,\?\*/+-]*)?$')
> +__regex_pointer_declaration_missing_whitespace = re.compile(r'[a-zA-Z0-9]\*')
>
>  skip_leading_whitespace_check = False
>  skip_trailing_whitespace_check = False
> @@ -157,6 +158,15 @@ def if_and_for_end_with_bracket_check(line):
>      return True
>
>
> +def pointer_whitespace_check(line):
> +    """Return TRUE if there is not an asterisk between a pointer name and the

s/asterisk/space/

Otherwise:

Acked-by: Russell Bryant <russell at ovn.org>

> +       asterisk that denotes this is a apionter type, ie: 'struct foo*'"""
> +
> +    if __regex_pointer_declaration_missing_whitespace.search(line) is not None:
> +        return True
> +    return False

or I guess you could make this one line as:

   return __regex_...search(line) is not None

not a big deal, though


More information about the dev mailing list