[ovs-dev] [PATCH] ovs-fields.7: Use a more general approach to groff encodings.

[Justin Pettit]

> On Jan 26, 2017, at 10:26 AM, Ben Pfaff <blp at ovn.org> wrote:
> 
> It turns out that, since groff 1.20 around 2009, groff comes with a
> preprocessor named "preconv" that can fix encoding issues.  Use it instead
> of the existing hack.

Geez, you didn't know that?  Where've you been?  

> --- a/lib/automake.mk
> +++ b/lib/automake.mk
> @@ -1,4 +1,4 @@
> -# Copyright (C) 2009, 2010, 2011, 2012, 2013, 2014, 2015, 2016 Nicira, Inc.
> +# Copyright (C) 2009, 2010, 2011, 2012, 2013, 2014, 2015, 2016, 2017 Nicira, Inc.
> #
> # Copying and distribution of this file, with or without modification,
> # are permitted in any medium without royalty provided the copyright
> @@ -543,6 +543,6 @@ lib/ovs-fields.7: $(srcdir)/build-aux/extract-ofp-fields include/openvswitch/met
> 	$(AM_V_GEN)PYTHONIOENCODING=utf8 $(run_python) $< \
>             --ovs-version=$(VERSION) ovs-fields \
> 	    $(srcdir)/include/openvswitch/meta-flow.h \
> -            $(srcdir)/lib/meta-flow.xml > $@.tmp
> +            $(srcdir)/lib/meta-flow.xml | preconv -e utf-8 > $@.tmp

I prefer the forthcoming "precog" preprocessor that doesn't even need any arguments, but this will do for now.

--Justin