[ovs-dev] [patch_v6 3/8] dpdk: Remove batch sorting in userspace conntrack.

[Daniele Di Proietto]

Thanks for posting this as a separate patch, it makes the review easier.

The idea and the patch look good to me.

One comment:

with this code we don't need the ctxs array, we can just have a single
ctx in the for loop.

Other than that:

Acked-by: Daniele Di Proietto <diproiettod at vmware.com>

2017-02-21 9:36 GMT-08:00 Flavio Leitner <fbl at sysclose.org>:
> On Thu, Feb 16, 2017 at 12:47:34AM -0800, Darrell Ball wrote:
>> Packet batch sorting is removed for three reasons:
>>
>> 1) The following patches for NAT change the locking
>>     marshalling so batching loses benefit.
>>
>> 2) For real mixtures of flows either in hypervisors
>>    or gateways, the batch sorting won't provide benefit
>>    and will just be a tax.
>>
>> 3) Code clarity.
>>
>> Signed-off-by: Darrell Ball <dlu998 at gmail.com>
>> ---
>
> I can't tell about the real performance impact but I'd agree
> with the second point.
>
> Acked-by: Flavio Leitner <fbl at sysclose.org>
>
>
> _______________________________________________
> dev mailing list
> dev at openvswitch.org
> https://mail.openvswitch.org/mailman/listinfo/ovs-dev