[ovs-dev] [PATCH 1/2] checkpatch: Check for pointer whitespace.

Joe Stringer joe at ovn.org
Thu Mar 9 20:35:18 UTC 2017


On 8 March 2017 at 11:23, Russell Bryant <russell at ovn.org> wrote:
> On Wed, Mar 8, 2017 at 12:54 PM, Joe Stringer <joe at ovn.org> wrote:
>> Signed-off-by: Joe Stringer <joe at ovn.org>
>> ---
>>  utilities/checkpatch.py | 14 ++++++++++++++
>>  1 file changed, 14 insertions(+)
>>
>> diff --git a/utilities/checkpatch.py b/utilities/checkpatch.py
>> index 26eb5c32b9bc..e795646de4a8 100755
>> --- a/utilities/checkpatch.py
>> +++ b/utilities/checkpatch.py
>> @@ -68,6 +68,7 @@ __regex_is_for_if_single_line_bracket = \
>>      re.compile(r'^ +(if|for|while) \(.*\)')
>>  __regex_ends_with_bracket = \
>>      re.compile(r'[^\s]\) {(\s+/\*[\s\Sa-zA-Z0-9\.,\?\*/+-]*)?$')
>> +__regex_pointer_declaration_missing_whitespace = re.compile(r'[a-zA-Z0-9]\*')
>>
>>  skip_leading_whitespace_check = False
>>  skip_trailing_whitespace_check = False
>> @@ -157,6 +158,15 @@ def if_and_for_end_with_bracket_check(line):
>>      return True
>>
>>
>> +def pointer_whitespace_check(line):
>> +    """Return TRUE if there is not an asterisk between a pointer name and the
>
> s/asterisk/space/
>
> Otherwise:
>
> Acked-by: Russell Bryant <russell at ovn.org>

Fixed these up and applied to master, thanks.


More information about the dev mailing list