[ovs-dev] [RFC] lib/automake.mk: remove runtime directories
Aaron Conole
aconole at redhat.com
Wed Mar 15 16:24:12 UTC 2017
Markos Chandras <mchandras at suse.de> writes:
> Hi Aaron,
>
> On 03/09/2017 03:35 PM, Aaron Conole wrote:
>> The Open vSwitch run, log, and DB directories are installed as part of the
>> normal `make install` process. However, this means they are created with
>> user and group ownership that may conflict with the desired user. For
>> example, running `make install` as root will install those files as
>> root:root, whereas the runtime user desired may be openvswitch:openvswitch.
>>
>> Since these directories are automatically created as part of the ovs-ctl
>> command, and with the correct user:group permissions, it makes sense to
>> delay creation until these directories are actually required.
>>
>> Signed-off-by: Aaron Conole <aconole at redhat.com>
>
> It looks reasonable to me. Thanks!
>
> Reviewed-by: Markos Chandras <mchandras at suse.de>
Thanks Markos. I'm planning on submitting this as a full PATCH once
I've double checked that it doesn't break any of my existing test
scripts and rpm builds.
-Aaron
More information about the dev
mailing list