[ovs-dev] [PATCH 3/3] ofproto-dpif-xlate.c: Include controller traffic for NetFlow.

[Justin Pettit]

> On Mar 23, 2017, at 10:03 AM, Jarno Rajahalme <jarno at ovn.org> wrote:
> 
> 
>> On Mar 22, 2017, at 11:26 PM, Justin Pettit <jpettit at ovn.org> wrote:
>> 
>> The code previously did not include packets forwarded to the controller
>> in NetFlow, as it considered this control traffic.  That is debatable for
>> deployments where the first packet of every flow is sent to the
>> controller for a forwarding decision that may eventually be executed on
>> the switch.
>> 
> 
> This argues for including controller packets in NetFlow...
> 
>> However, we are starting to send more traffic to local controllers for
>> non-forwarding purposes such as logging.  These packets are already
>> being forwarded and only copies are being sent to the controller,
> 
> and this seems to be arguing for the status quo (why should logging copies be included in NetFlow?)...
> 
>> so not
>> accounting for them will incorrectly under-report NetFlow statistics.
>> 
> 
> But this then concludes that we must account them anyway.
> 
> Maybe you mean that even though a copy of the packet is being sent to controller (maybe for logging purposes), we should still NetFlow the original (upcalled) packet. If so:
> 
> Acked-by: Jarno Rajahalme <jarno at ovn.org>

Yes, that's what I meant.  I tried to clarify the description a little and pushed the series to master.

Thanks for the review.

--Justin