[ovs-dev] [PATCH v3 1/7] checkpatch: introduce a flexible framework
Ben Pfaff
blp at ovn.org
Mon May 1 19:49:38 UTC 2017
On Mon, May 01, 2017 at 03:44:37PM -0400, Aaron Conole wrote:
> Developers wishing to add checks to checkpatch sift through an adhoc mess,
> currently. The process goes something like:
> 1. Figure out what to test in the patch
> 2. Write some code, quickly, that checks for that condition
> 3. Look through the statemachine to find where the check should go
> 4. ignore parts of the above and just throw something together
>
> That worked fine for the initial development, but as interesting new tests
> are developed, it is important to have a more flexible framework that lets
> a developer just plug in a new test, easily.
>
> This commit brings in a new framework that allows plugging in checks very
> quickly. Hook up the line-length test as an initial demonstration.
>
> Signed-off-by: Aaron Conole <aconole at redhat.com>
With this, I get:
../utilities/checkpatch.py:180:12: E999 SyntaxError: invalid syntax
where the cited line is:
lambda(x): print_warning("Line is greater than 79-characters long", x)}
I'm using:
$ flake8 --version
3.2.1 (mccabe: 0.5.3, pycodestyle: 2.2.0, pyflakes: 1.3.0) CPython 3.5.1+ on Linux
Thanks,
Ben.
More information about the dev
mailing list