[ovs-dev] [PATCH 05/27] ovn-sbctl, ovn-nbctl, ovs-vsctl: Remove useless record id methods.
Ben Pfaff
blp at ovn.org
Wed May 3 15:27:01 UTC 2017
On Tue, May 02, 2017 at 04:34:44PM -0400, Russell Bryant wrote:
> On Tue, May 2, 2017 at 4:30 PM, Russell Bryant <russell at ovn.org> wrote:
> > On Sun, Apr 30, 2017 at 7:22 PM, Ben Pfaff <blp at ovn.org> wrote:
> >> These only did anything if both the first two members of the struct were
> >> nonnull, as you can see from the first test in get_row_by_id() in
> >> lib/db-ctl-base.c, so these never did anything useful and I can't figure
> >> out why they're there.
> >>
> >> Signed-off-by: Ben Pfaff <blp at ovn.org>
> >> ---
> >> ovn/utilities/ovn-nbctl.c | 3 ---
> >> ovn/utilities/ovn-sbctl.c | 7 -------
> >> utilities/ovs-vsctl.c | 16 +++++-----------
> >> 3 files changed, 5 insertions(+), 21 deletions(-)
> >
> > This doesn't compile for me.
>
> though I see now that the next patch fixes it, so either fix the build
> here or wait for the ack on the next one before applying.
Oops! I actually found and fixed this same thing while rebasing against
master a few minutes ago. Thanks for pointing it out.
More information about the dev
mailing list