[ovs-dev] [PATCH] ovs-atomic: Report error for contradictory configuration.

Joe Stringer joe at ovn.org
Wed May 3 20:39:46 UTC 2017


On 3 May 2017 at 11:05, Ben Pfaff <blp at ovn.org> wrote:
> A user reported that GCC 5.x was using the atomic fallback for GCC 4.x
> because the test
>      #elif __GNUC__ >= 4 && __GNUC_MINOR__ >= 7
> didn't include GCC 5.  However, GCC 5+ has <stdatomic.h> and shouldn't use
> any of the GCC-specific cases at all.  I think that this user was actually
> pulling our atomics out into third-party code that probably didn't define
> HAVE_STDATOMIC_H properly, so this commit both avoids that problem for
> them in the future and clarifies the intent of the ovs-atomic header.
>
> Signed-off-by: Ben Pfaff <blp at ovn.org>

Acked-by: Joe Stringer <joe at ovn.org>


More information about the dev mailing list