[ovs-dev] [PATCH v2 02/13] ovn-northd: Propagate Neutron datapath names to southbound database.

Ben Pfaff blp at ovn.org
Wed May 3 23:14:26 UTC 2017


On Wed, May 03, 2017 at 02:59:15PM -0700, Andy Zhou wrote:
> On Wed, May 3, 2017 at 8:45 AM, Ben Pfaff <blp at ovn.org> wrote:
> > It's much easier to see what's going on in the southbound database if
> > human-friendly names are available.
> >
> > Really it's too bad that we didn't put the human-friendly name in "name"
> > and the UUID in something like "external_ids:neutron-uuid", but it'll take
> > more coordination to change that at this point and it may not be worth it.
> >
> > Signed-off-by: Ben Pfaff <blp at ovn.org>
> Acked-by: Andy Zhou <azhou at ovn.org>

Thanks!

> > @@ -734,6 +739,9 @@ build_datapaths(struct northd_context *ctx, struct hmap *datapaths)
> >              if (*name) {
> >                  smap_add(&ids, "name", name);
> >              }
> In the definition of both nbrec_loical_router and
> nbrec_logical_switch, the comment of the 'name' filed
> says it should nonnull.  If that is true, then we don't need this check?

Oh, thanks for noticing.  I simplified this code.


More information about the dev mailing list