[ovs-dev] [PATCH] dpif-netdev/netdev-dpdk: Fix line lengths.

Kevin Traynor ktraynor at redhat.com
Fri May 5 10:52:05 UTC 2017


Fix line lengths to be <= 79 as per coding style and so that checkpatch
will not show up existing warnings on these files.

Signed-off-by: Kevin Traynor <ktraynor at redhat.com>
---
 lib/dpif-netdev.c | 23 ++++++++++++++---------
 lib/netdev-dpdk.c |  6 ++++--
 2 files changed, 18 insertions(+), 11 deletions(-)

diff --git a/lib/dpif-netdev.c b/lib/dpif-netdev.c
index 4ee5d05..bc62a6c 100644
--- a/lib/dpif-netdev.c
+++ b/lib/dpif-netdev.c
@@ -341,5 +341,5 @@ struct dp_netdev_rxq {
                                           queue doesn't need to be pinned to a
                                           particular core. */
-    struct dp_netdev_pmd_thread *pmd;  /* pmd thread that will poll this queue. */
+    struct dp_netdev_pmd_thread *pmd;  /* pmd thread that polls this queue. */
 };
 
@@ -353,5 +353,5 @@ struct dp_netdev_port {
     unsigned n_rxq;             /* Number of elements in 'rxq' */
     bool dynamic_txqs;          /* If true XPS will be used. */
-    unsigned *txq_used;         /* Number of threads that uses each tx queue. */
+    unsigned *txq_used;         /* Number of threads that use each tx queue. */
     struct ovs_mutex txq_used_mutex;
     char *type;                 /* Port type as requested by user. */
@@ -4465,5 +4465,6 @@ static inline void
 dp_netdev_queue_batches(struct dp_packet *pkt,
                         struct dp_netdev_flow *flow, const struct miniflow *mf,
-                        struct packet_batch_per_flow *batches, size_t *n_batches)
+                        struct packet_batch_per_flow *batches,
+                        size_t *n_batches)
 {
     struct packet_batch_per_flow *batch = flow->batch;
@@ -4485,6 +4486,6 @@ dp_netdev_queue_batches(struct dp_packet *pkt,
  * 'packets' array (they have been moved to the beginning of the vector).
  *
- * If 'md_is_valid' is false, the metadata in 'packets' is not valid and must be
- * initialized by this function using 'port_no'.
+ * If 'md_is_valid' is false, the metadata in 'packets' is not valid and must
+ * be initialized by this function using 'port_no'.
  */
 static inline size_t
@@ -4540,5 +4541,6 @@ emc_processing(struct dp_netdev_pmd_thread *pmd,
     }
 
-    dp_netdev_count_packet(pmd, DP_STAT_EXACT_HIT, size - n_dropped - n_missed);
+    dp_netdev_count_packet(pmd, DP_STAT_EXACT_HIT,
+                           size - n_dropped - n_missed);
 
     return dp_packet_batch_size(packets_);
@@ -4546,5 +4548,6 @@ emc_processing(struct dp_netdev_pmd_thread *pmd,
 
 static inline void
-handle_packet_upcall(struct dp_netdev_pmd_thread *pmd, struct dp_packet *packet,
+handle_packet_upcall(struct dp_netdev_pmd_thread *pmd,
+                     struct dp_packet *packet,
                      const struct netdev_flow_key *key,
                      struct ofpbuf *actions, struct ofpbuf *put_actions,
@@ -4729,5 +4732,6 @@ dp_netdev_input__(struct dp_netdev_pmd_thread *pmd,
     enum { PKT_ARRAY_SIZE = NETDEV_MAX_BURST };
 #endif
-    OVS_ALIGNED_VAR(CACHE_LINE_SIZE) struct netdev_flow_key keys[PKT_ARRAY_SIZE];
+    OVS_ALIGNED_VAR(CACHE_LINE_SIZE)
+        struct netdev_flow_key keys[PKT_ARRAY_SIZE];
     struct packet_batch_per_flow batches[PKT_ARRAY_SIZE];
     long long now = time_msec();
@@ -4741,5 +4745,6 @@ dp_netdev_input__(struct dp_netdev_pmd_thread *pmd,
         /* Get ingress port from first packet's metadata. */
         in_port = packets->packets[0]->md.in_port.odp_port;
-        fast_path_processing(pmd, packets, keys, batches, &n_batches, in_port, now);
+        fast_path_processing(pmd, packets, keys, batches, &n_batches,
+                             in_port, now);
     }
 
diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c
index 609b8da..62f8b43 100644
--- a/lib/netdev-dpdk.c
+++ b/lib/netdev-dpdk.c
@@ -1126,5 +1126,6 @@ netdev_dpdk_process_devargs(const char *devargs, char **errp)
         } else {
             /* Attach unsuccessful */
-            VLOG_WARN_BUF(errp, "Error attaching device '%s' to DPDK", devargs);
+            VLOG_WARN_BUF(errp, "Error attaching device '%s' to DPDK",
+                          devargs);
             return -1;
         }
@@ -3079,5 +3080,6 @@ egress_policer_qos_get(const struct qos_conf *conf, struct smap *details)
 
 static bool
-egress_policer_qos_is_equal(const struct qos_conf *conf, const struct smap *details)
+egress_policer_qos_is_equal(const struct qos_conf *conf,
+                            const struct smap *details)
 {
     struct egress_policer *policer =
-- 
1.8.3.1



More information about the dev mailing list