[ovs-dev] [PATCH v6 4/4] Signed-off-by: Alin Gabriel Serdean <aserdean at cloudbasesolutions.com>

Sairam Venugopal vsairam at vmware.com
Mon May 8 23:24:05 UTC 2017


Yin,

Can you rebase and rebuild your changes? OvsTcpSegmentNBL arguments have changed and this patch breaks compilation.

Can you add commit msgs to your patches? 

This commit title says: "Signed-off-by:Alin Gabriel…” Can you fix this?

Thanks,
Sairam




On 5/8/17, 3:38 PM, "ovs-dev-bounces at openvswitch.org on behalf of Yin Lin" <ovs-dev-bounces at openvswitch.org on behalf of linyi at vmware.com> wrote:

>From: Alin Gabriel Serdean <aserdean at cloudbasesolutions.com>
>
>---
> datapath-windows/ovsext/Actions.c | 38 ++++++++++++++++++++++++++++++++++++++
> 1 file changed, 38 insertions(+)
>
>diff --git a/datapath-windows/ovsext/Actions.c b/datapath-windows/ovsext/Actions.c
>index d1938f3..bb1e6ea 100644
>--- a/datapath-windows/ovsext/Actions.c
>+++ b/datapath-windows/ovsext/Actions.c
>@@ -1572,6 +1572,44 @@ OvsUpdateAddressAndPort(OvsForwardingContext *ovsFwdCtx,
>         }
>         *portField = newPort;
>     }
>+    PNET_BUFFER_LIST curNbl = ovsFwdCtx->curNbl;
>+    PNET_BUFFER_LIST newNbl = NULL;
>+    if (layers->isTcp) {
>+        UINT32 mss = OVSGetTcpMSS(curNbl);
>+        if (mss) {
>+            OVS_LOG_TRACE("l4Offset %d", layers->l4Offset);
>+            newNbl = OvsTcpSegmentNBL(ovsFwdCtx->switchContext, curNbl, layers,
>+                                      mss, 0);
>+            if (newNbl == NULL) {
>+                OVS_LOG_ERROR("Unable to segment NBL");
>+                return NDIS_STATUS_FAILURE;
>+            }
>+            /* Clear out LSO flags after this point */
>+            NET_BUFFER_LIST_INFO(newNbl, TcpLargeSendNetBufferListInfo) = 0;
>+        }
>+    }
>+    /* If we didn't split the packet above, make a copy now */
>+    if (newNbl == NULL) {
>+        csumInfo.Value = NET_BUFFER_LIST_INFO(curNbl,
>+                                              TcpIpChecksumNetBufferListInfo);
>+        OvsApplySWChecksumOnNB(layers, curNbl, &csumInfo);
>+    }
>+
>+    if (newNbl) {
>+        curNbl = newNbl;
>+        OvsCompleteNBLForwardingCtx(ovsFwdCtx,
>+                                    L"Complete after cloning NBL for encapsulation");
>+        OvsInitForwardingCtx(ovsFwdCtx, ovsFwdCtx->switchContext,
>+                             newNbl, ovsFwdCtx->srcVportNo, 0,
>+                             NET_BUFFER_LIST_SWITCH_FORWARDING_DETAIL(newNbl),
>+                             ovsFwdCtx->completionList,
>+                             &ovsFwdCtx->layers, FALSE);
>+        ovsFwdCtx->curNbl = newNbl;
>+    }
>+
>+    NET_BUFFER_LIST_INFO(curNbl,
>+                         TcpIpChecksumNetBufferListInfo) = 0;
>+
>     return NDIS_STATUS_SUCCESS;
> }
> 
>-- 
>2.10.2.windows.1
>
>_______________________________________________
>dev mailing list
>dev at openvswitch.org
>https://mail.openvswitch.org/mailman/listinfo/ovs-dev


More information about the dev mailing list