[ovs-dev] [PATCH 1/2] Revert "tunneling: Avoid recirculation on datapath."

Darrell Ball dball at vmware.com
Wed May 10 01:44:50 UTC 2017


It might be good to add a test that checks that “all the fields” associated with tunnel header can be
matched in the underlay bridge context
I did a quick test with your patch:
ip_proto/nw_proto was fine and matching GRE
I could also successfully match on ip_dst/nw_dst but not on ip_src/nw_src, for example.



On 5/9/17, 4:55 AM, "ovs-dev-bounces at openvswitch.org on behalf of Zoltán Balogh" <ovs-dev-bounces at openvswitch.org on behalf of zoltan.balogh at ericsson.com> wrote:

    Hi,
    
    I created a patch that updates flow and base_flow L2/L3 members when pushing packet to tunnel, and fixes statistics on underlay bridge. 
    I posted it to the original thread:
    https://urldefense.proofpoint.com/v2/url?u=https-3A__mail.openvswitch.org_pipermail_ovs-2Ddev_2017-2DMay_332265.html&d=DwICAg&c=uilaK90D4TOVoH58JNXRgQ&r=BVhFA09CGX7JQ5Ih-uZnsw&m=lNfYVOoPGZRl8beVCPBv23EX5aIqrWrIRcpodjAIkwE&s=6UWX4CTnpSwFgj4kj0bhBaDTfh5fldH_61-lbc9AG8U&e= 
    
    As I see, you have not reverted the "Avoid recirculation" patch yet. If my new patch is accepted then it's not needed to revert the original commit. Could you have a look at the new patch, please?
    
    If you are going to revert the original patch, then I'm going to merge the new patch with the original one and resend it to the list.
    
    Best regards,
    Zoltan
    
    
    > -----Original Message-----
    > From: ovs-dev-bounces at openvswitch.org [mailto:ovs-dev-bounces at openvswitch.org] On Behalf Of Joe Stringer
    > Sent: Tuesday, May 09, 2017 5:41 AM
    > To: William Tu <u9012063 at gmail.com>
    > Cc: ovs-dev <ovs-dev at openvswitch.org>
    > Subject: Re: [ovs-dev] [PATCH 1/2] Revert "tunneling: Avoid recirculation on datapath."
    > 
    > On 8 May 2017 at 17:35, William Tu <u9012063 at gmail.com> wrote:
    > > Hi Joe and Greg,
    > >
    > > Maybe it's better I put this revert tunneling patch (1/2) and its
    > > tunnel-tests (2/2) in one patch, so the "make check" can pass?
    > 
    > They can be separate. It's currently broken, the revert will fix it.
    > The test can be an independent submission. I'd rather not fold yet
    > more changes into the revert.
    > _______________________________________________
    > dev mailing list
    > dev at openvswitch.org
    > https://urldefense.proofpoint.com/v2/url?u=https-3A__mail.openvswitch.org_mailman_listinfo_ovs-2Ddev&d=DwICAg&c=uilaK90D4TOVoH58JNXRgQ&r=BVhFA09CGX7JQ5Ih-uZnsw&m=lNfYVOoPGZRl8beVCPBv23EX5aIqrWrIRcpodjAIkwE&s=x9d45zty5nZTMZsW3A2BSENnB72aAhk6Ed8hMQ3h_xA&e= 
    _______________________________________________
    dev mailing list
    dev at openvswitch.org
    https://urldefense.proofpoint.com/v2/url?u=https-3A__mail.openvswitch.org_mailman_listinfo_ovs-2Ddev&d=DwICAg&c=uilaK90D4TOVoH58JNXRgQ&r=BVhFA09CGX7JQ5Ih-uZnsw&m=lNfYVOoPGZRl8beVCPBv23EX5aIqrWrIRcpodjAIkwE&s=x9d45zty5nZTMZsW3A2BSENnB72aAhk6Ed8hMQ3h_xA&e= 
    







More information about the dev mailing list