[ovs-dev] [PATCH] datapath-windows: Set Version correctly for OVSExt

Alin Serdean aserdean at cloudbasesolutions.com
Mon May 15 20:59:58 UTC 2017


I think the same effect can be achieved using this incremental:
---
 datapath-windows/ovsext/ovsext.rc | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/datapath-windows/ovsext/ovsext.rc b/datapath-windows/ovsext/ovsext.rc
index a7cf0a7..8896256 100644
--- a/datapath-windows/ovsext/ovsext.rc
+++ b/datapath-windows/ovsext/ovsext.rc
@@ -33,12 +33,12 @@ BEGIN
         BEGIN
             VALUE "CompanyName", "The Linux Foundation (R)"
             VALUE "FileDescription", "Open vSwitch Extension"
-            VALUE "FileVersion", STR(Version)
+            VALUE "FileVersion", STR(VersionWithCommas)
             VALUE "InternalName", "OVSExt.SYS"
             VALUE "LegalCopyright", "Licensed under the Apache License, Version 2.0 (the ""License"")"
             VALUE "OriginalFilename", "OVSExt.SYS"
             VALUE "ProductName", "Open vSwitch"
-            VALUE "ProductVersion", STR(Version)
+            VALUE "ProductVersion", STR(VersionWithCommas)
         END
     END
     BLOCK "VarFileInfo"
-- 
2.10.2.windows.1

Without the need to change the vcxproj.

> -----Original Message-----
> From: ovs-dev-bounces at openvswitch.org [mailto:ovs-dev-
> bounces at openvswitch.org] On Behalf Of Alin Serdean
> Sent: Monday, May 15, 2017 11:50 PM
> To: Shashank Ram <rams at vmware.com>; dev at openvswitch.org
> Subject: Re: [ovs-dev] [PATCH] datapath-windows: Set Version correctly for
> OVSExt
> 
> Thanks a lot for the patch.
> 
> I had to double look the changes.
> 
> It may be worth adding to the commit message that this impacts the way the
> "ovsext.sys" product version will be generated.
> At the moment, only the file version of the sys attributes will be generated
> correctly. The product version is being set to the text "Version".
> 
> Mind changing the commit message to "set product version correctly".
> 
> Also, a small nit you `VER_TO_STR` applied only on `ProductVersion`.
> 
> Alin.
> 
> > -----Original Message-----
> > From: ovs-dev-bounces at openvswitch.org [mailto:ovs-dev-
> > bounces at openvswitch.org] On Behalf Of Shashank Ram
> > Sent: Saturday, May 6, 2017 1:58 AM
> > To: dev at openvswitch.org
> > Subject: [ovs-dev] [PATCH] datapath-windows: Set Version correctly for
> > OVSExt


More information about the dev mailing list