[ovs-dev] [PATCH v2] python ovs: Fix SSL exceptions with pyOpenSSL v0.13

Lance Richardson lrichard at redhat.com
Tue May 16 18:15:00 UTC 2017


> From: nusiddiq at redhat.com
> To: dev at openvswitch.org
> Sent: Monday, 15 May, 2017 11:39:25 AM
> Subject: [ovs-dev] [PATCH v2] python ovs: Fix SSL exceptions with pyOpenSSL	v0.13
> 
> From: Numan Siddique <nusiddiq at redhat.com>
> 
> Centos provides pyOpenSSL version pyOpenSSL-0.13.1-3.el7.x86_64.
> There are 2 issues using this version, which this patch fixes
> 
>  - The test case "simple idl verify notify - SSL" is skipped.
>    This is because "python -m OpenSSL.SSL" is used to detect the
>    presence of pyOpenSSL package. pyOpenSSL v0.13 has C python
>    modules because of which the above command returns 1.
>    So this patch fixes this by using 'python -c "import OpenSSL.SSL"'.
> 
>  - The SSL.Context class do not have the function "set_session_cache_mode"
>    defined. Setting the session cache mode has an effect for server-side
>    sessions and doesn't make much sense for client-side sessions.
>    Since python ovs doesn't support "pssl" connection mode, this patch
>    deletes the reference to this function.
> 
> I have not tested with older versions (< 0.13) of pyOpenSSL.
> 
> Signed-off-by: Numan Siddique <nusiddiq at redhat.com>
> ---

LGTM

Acked-by: Lance Richardson <lrichard at redhat.com>


More information about the dev mailing list